* [PATCH] libext2fs: add missing check for utf8lookup()'s return value
@ 2019-05-10 18:20 Theodore Ts'o
2019-05-12 2:38 ` Gabriel Krisman Bertazi
0 siblings, 1 reply; 2+ messages in thread
From: Theodore Ts'o @ 2019-05-10 18:20 UTC (permalink / raw)
To: Ext4 Developers List; +Cc: Theodore Ts'o, Gabriel Krisman Bertazi
Fixes-Coverity-Bug: 1442630
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: Gabriel Krisman Bertazi <krisman@collabora.com>
---
lib/ext2fs/nls_utf8.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/ext2fs/nls_utf8.c b/lib/ext2fs/nls_utf8.c
index 42148099a..e4c4e7a30 100644
--- a/lib/ext2fs/nls_utf8.c
+++ b/lib/ext2fs/nls_utf8.c
@@ -789,6 +789,8 @@ static int utf8byte(struct utf8cursor *u8c)
}
leaf = utf8lookup(u8c->data, u8c->hangul, u8c->s);
+ if (!leaf)
+ return -1;
ccc = LEAF_CCC(leaf);
}
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libext2fs: add missing check for utf8lookup()'s return value
2019-05-10 18:20 [PATCH] libext2fs: add missing check for utf8lookup()'s return value Theodore Ts'o
@ 2019-05-12 2:38 ` Gabriel Krisman Bertazi
0 siblings, 0 replies; 2+ messages in thread
From: Gabriel Krisman Bertazi @ 2019-05-12 2:38 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Ext4 Developers List
"Theodore Ts'o" <tytso@mit.edu> writes:
> Fixes-Coverity-Bug: 1442630
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> Cc: Gabriel Krisman Bertazi <krisman@collabora.com>
> ---
> lib/ext2fs/nls_utf8.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com>
We should get this applied on the kernel side as well.
Thanks,
--
Gabriel Krisman Bertazi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-12 2:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-10 18:20 [PATCH] libext2fs: add missing check for utf8lookup()'s return value Theodore Ts'o
2019-05-12 2:38 ` Gabriel Krisman Bertazi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).