From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] unicode: add missing check for an error return from utf8lookup()
Date: Sun, 12 May 2019 17:18:20 -0400 [thread overview]
Message-ID: <85lfzbbcdf.fsf@collabora.com> (raw)
In-Reply-To: <20190512085752.1791-1-tytso@mit.edu> (Theodore Ts'o's message of "Sun, 12 May 2019 04:57:52 -0400")
"Theodore Ts'o" <tytso@mit.edu> writes:
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> Cc: Gabriel Krisman Bertazi <krisman@collabora.com>
Acked-by: Gabriel Krisman Bertazi <krisman@collabora.com>
> ---
> fs/unicode/utf8-norm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/unicode/utf8-norm.c b/fs/unicode/utf8-norm.c
> index 20d440c3f2db..801ed6d2ea37 100644
> --- a/fs/unicode/utf8-norm.c
> +++ b/fs/unicode/utf8-norm.c
> @@ -714,6 +714,8 @@ int utf8byte(struct utf8cursor *u8c)
> }
>
> leaf = utf8lookup(u8c->data, u8c->hangul, u8c->s);
> + if (!leaf)
> + return -1;
> ccc = LEAF_CCC(leaf);
> }
--
Gabriel Krisman Bertazi
prev parent reply other threads:[~2019-05-12 21:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-12 8:57 [PATCH] unicode: add missing check for an error return from utf8lookup() Theodore Ts'o
2019-05-12 21:18 ` Gabriel Krisman Bertazi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85lfzbbcdf.fsf@collabora.com \
--to=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).