From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org,
"Lakshmipathi.G" <lakshmipathi.ganapathi@collabora.co.uk>
Subject: Re: [PATCH v3 2/2] shared/012: Add tests for filename casefolding feature
Date: Wed, 12 Jun 2019 01:01:46 -0400 [thread overview]
Message-ID: <85y327z9ad.fsf@collabora.com> (raw)
In-Reply-To: <20190611121546.GC2774@mit.edu> (Theodore Ts'o's message of "Tue, 11 Jun 2019 08:15:46 -0400")
"Theodore Ts'o" <tytso@mit.edu> writes:
> On Mon, Jun 10, 2019 at 01:35:41PM -0400, Gabriel Krisman Bertazi wrote:
>> From: "Lakshmipathi.G" <lakshmipathi.ganapathi@collabora.co.uk>
>>
>> This new test implements verification for the per-directory
>> case-insensitive feature, as supported by the reference implementation
>> in Ext4.
>>
>> Signed-off-by: Lakshmipathi.G <lakshmipathi.ganapathi@collabora.co.uk>
>> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
>> [Rewrite to support feature design]
>> [Refactor to simplify implementation]
>
> I tried out this test, and it's apparently failing for me using
> e2fsprogs 1.45.2; it looks like it's a whitespace issue?
Hi Ted,
Yes, definitely just whitespace. But i don't understand why you are
getting this behavior. I tried both with the master branch of e2fsprogs
and the tagged commit of v1.45.2 and on both occasions the test succeed
in my system. For sure I can use filter_spaces but I'm puzzled why I
can't reproduce this.
>
> shared/012 [08:14:07][ 146.388509] run fstests shared/012 at 2019-06-11 08:14:07
> [08:14:08]- output mismatch (see /results/ext4/results-4k/shared/012.out.bad)
> --- tests/shared/012.out 2019-06-10 00:02:54.000000000 -0400
> +++ /results/ext4/results-4k/shared/012.out.bad 2019-06-11 08:14:08.487418272 -0400
> @@ -1,8 +1,8 @@
> QA output created by 012
> -SCRATCH_MNT/basic Extents, Casefold
> -SCRATCH_MNT/basic Extents
> -SCRATCH_MNT/casefold_flag_removal Extents, Casefold
> -SCRATCH_MNT/casefold_flag_removal Extents, Casefold
> +SCRATCH_MNT/basic Extents, Casefold
> +SCRATCH_MNT/basic Extents
> ...
> (Run 'diff -u /root/xfstests/tests/shared/012.out /results/ext4/results-4k/shared/012.out.bad' to see the entire diff)
> Ran: shared/012
> Failures: shared/012
> Failed 1 of 1 tests
> Xunit report: /results/ext4/results-4k/result.xml
>
> root@kvm-xfstests:~# diff -u /root/xfstests/tests/shared/012.out /results/ext4/results-4k/shared/012.out.bad
> --- /root/xfstests/tests/shared/012.out 2019-06-10 00:02:54.000000000 -0400
> +++ /results/ext4/results-4k/shared/012.out.bad 2019-06-11 08:14:08.487418272 -0400
> @@ -1,8 +1,8 @@
> QA output created by 012
> -SCRATCH_MNT/basic Extents, Casefold
> -SCRATCH_MNT/basic Extents
> -SCRATCH_MNT/casefold_flag_removal Extents, Casefold
> -SCRATCH_MNT/casefold_flag_removal Extents, Casefold
> +SCRATCH_MNT/basic Extents, Casefold
> +SCRATCH_MNT/basic Extents
> +SCRATCH_MNT/casefold_flag_removal Extents, Casefold
> +SCRATCH_MNT/casefold_flag_removal Extents, Casefold
> SCRATCH_MNT/flag_inheritance/d1/d2/d3 Extents, Casefold
> SCRATCH_MNT/symlink/ind1/TARGET
> mv: cannot stat 'SCRATCH_MNT/rename/rename': No such file or directory
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2019-06-12 5:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 17:35 [PATCH v3 1/2] common/casefold: Add infrastructure to test filename casefold feature Gabriel Krisman Bertazi
2019-06-10 17:35 ` [PATCH v3 2/2] shared/012: Add tests for filename casefolding feature Gabriel Krisman Bertazi
2019-06-11 12:15 ` Theodore Ts'o
2019-06-12 5:01 ` Gabriel Krisman Bertazi [this message]
2019-06-12 12:32 ` Theodore Ts'o
2019-06-12 18:32 ` Gabriel Krisman Bertazi
-- strict thread matches above, loose matches on Subject: below --
2019-06-12 18:40 [PATCH v3 1/2] common/casefold: Add infrastructure to test filename casefold feature Gabriel Krisman Bertazi
2019-06-12 18:40 ` [PATCH v3 2/2] shared/012: Add tests for filename casefolding feature Gabriel Krisman Bertazi
2019-06-16 14:44 ` Eryu Guan
2019-06-16 20:01 ` Theodore Ts'o
2019-06-20 11:29 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85y327z9ad.fsf@collabora.com \
--to=krisman@collabora.com \
--cc=fstests@vger.kernel.org \
--cc=lakshmipathi.ganapathi@collabora.co.uk \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).