From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@infradead.org>,
"Darrick J . Wong" <djwong@kernel.org>,
Ojaswin Mujoo <ojaswin@linux.ibm.com>,
Disha Goel <disgoel@linux.ibm.com>
Subject: Re: [RFCv4 9/9] iomap: Add couple of DIO tracepoints
Date: Sun, 16 Apr 2023 17:24:25 +0530 [thread overview]
Message-ID: <873550jb4e.fsf@doe.com> (raw)
In-Reply-To: <ZDuOtt6w+ZOcVv9w@infradead.org>
Christoph Hellwig <hch@infradead.org> writes:
> On Sat, Apr 15, 2023 at 01:14:30PM +0530, Ritesh Harjani (IBM) wrote:
>> Add iomap_dio_rw_queued and iomap_dio_complete tracepoint.
>> iomap_dio_rw_queued is mostly only to know that the request was queued
>> and -EIOCBQUEUED was returned. It is mostly iomap_dio_complete which has
>> all the details.
>
> Everything that is here looks good to me. But it seems like we lost
> the _begin tracepoint?
Sorry, my bad, I might have only partially understood your review
comment then. Will quickly send the next rev.
So in the next rev. will only just add a _begin tracepoint in
__iomap_dio_rw() function. Rest everything should be as is.
Right?
next prev parent reply other threads:[~2023-04-16 6:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-15 7:44 [RFCv4 0/9] ext2: DIO to use iomap Ritesh Harjani (IBM)
2023-04-15 7:44 ` [RFCv4 1/9] ext2/dax: Fix ext2_setsize when len is page aligned Ritesh Harjani (IBM)
2023-04-15 7:44 ` [RFCv4 2/9] fs/buffer.c: Add generic_buffer_fsync implementation Ritesh Harjani (IBM)
2023-04-16 5:56 ` Christoph Hellwig
2023-04-15 7:44 ` [RFCv4 3/9] ext4: Use generic_buffer_fsync() implementation Ritesh Harjani (IBM)
2023-04-15 7:44 ` [RFCv4 4/9] ext2: " Ritesh Harjani (IBM)
2023-04-15 7:44 ` [RFCv4 5/9] ext2: Move direct-io to use iomap Ritesh Harjani (IBM)
2023-04-16 5:59 ` Christoph Hellwig
2023-04-15 7:44 ` [RFCv4 6/9] fs.h: Add TRACE_IOCB_STRINGS for use in trace points Ritesh Harjani (IBM)
2023-04-15 7:44 ` [RFCv4 7/9] ext2: Add direct-io " Ritesh Harjani (IBM)
2023-04-15 7:44 ` [RFCv4 8/9] iomap: Remove IOMAP_DIO_NOSYNC unused dio flag Ritesh Harjani (IBM)
2023-04-15 7:44 ` [RFCv4 9/9] iomap: Add couple of DIO tracepoints Ritesh Harjani (IBM)
2023-04-16 5:59 ` Christoph Hellwig
2023-04-16 11:54 ` Ritesh Harjani [this message]
2023-04-16 6:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873550jb4e.fsf@doe.com \
--to=ritesh.list@gmail.com \
--cc=disgoel@linux.ibm.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).