From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@infradead.org>,
"Darrick J . Wong" <djwong@kernel.org>,
Ojaswin Mujoo <ojaswin@linux.ibm.com>,
Disha Goel <disgoel@linux.ibm.com>
Subject: Re: [RFCv3 07/10] ext2: Add direct-io trace points
Date: Fri, 14 Apr 2023 13:36:43 +0530 [thread overview]
Message-ID: <874jpizy3w.fsf@doe.com> (raw)
In-Reply-To: <ZDjr7tVpeOWaW44D@infradead.org>
Christoph Hellwig <hch@infradead.org> writes:
> So why do you add tracepoints in ext2 in addition to iomap?
1. It's very convenient to look into all ext2 filesystem activity by just
"trace-cmd -e ext2"
2. For cases in ext2 which fallbacks to buffered-io routine.
Adding a trace point specifically for ext2 can cover this path as well
as to how much got written via buffered-io path or in case there was an
error while doing that.
3. As of now there was no tracepoint added to ext2. Going forward it
will be quick and convenient to add any trace event for
debugging/observing other call paths too while development.
-ritesh
next prev parent reply other threads:[~2023-04-14 8:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 8:40 [RFCv3 00/10] ext2: DIO to use iomap Ritesh Harjani (IBM)
2023-04-13 8:40 ` [RFCv3 01/10] ext2/dax: Fix ext2_setsize when len is page aligned Ritesh Harjani (IBM)
2023-04-13 8:40 ` [RFCv3 02/10] libfs: Add __generic_file_fsync_nolock implementation Ritesh Harjani (IBM)
2023-04-14 5:59 ` Christoph Hellwig
2023-04-14 12:51 ` Jan Kara
2023-04-14 13:12 ` Christoph Hellwig
2023-04-14 14:20 ` Jan Kara
2023-04-14 14:29 ` Ritesh Harjani
2023-04-17 7:32 ` Jan Kara
2023-04-17 10:01 ` Ritesh Harjani
2023-04-13 8:40 ` [RFCv3 03/10] ext4: Use " Ritesh Harjani (IBM)
2023-04-13 8:40 ` [RFCv3 04/10] ext2: " Ritesh Harjani (IBM)
2023-04-13 8:40 ` [RFCv3 05/10] ext2: Move direct-io to use iomap Ritesh Harjani (IBM)
2023-04-13 8:40 ` [RFCv3 06/10] fs.h: Add TRACE_IOCB_STRINGS for use in trace points Ritesh Harjani (IBM)
2023-04-13 9:54 ` Christian Brauner
2023-04-13 10:15 ` Ritesh Harjani
2023-04-13 8:40 ` [RFCv3 07/10] ext2: Add direct-io " Ritesh Harjani (IBM)
2023-04-14 6:00 ` Christoph Hellwig
2023-04-14 8:06 ` Ritesh Harjani [this message]
2023-04-13 8:40 ` [RFCv3 08/10] iomap: Remove IOMAP_DIO_NOSYNC unused dio flag Ritesh Harjani (IBM)
2023-04-13 14:34 ` Darrick J. Wong
2023-04-13 8:40 ` [RFCv3 09/10] iomap: Minor refactor of iomap_dio_rw Ritesh Harjani (IBM)
2023-04-13 14:35 ` Darrick J. Wong
2023-04-14 6:00 ` Christoph Hellwig
2023-04-13 8:40 ` [RFCv3 10/10] iomap: Add trace points for DIO path Ritesh Harjani (IBM)
2023-04-13 14:42 ` Darrick J. Wong
2023-04-13 20:18 ` Ritesh Harjani
2023-04-14 2:16 ` Darrick J. Wong
2023-04-14 5:21 ` Ritesh Harjani
2023-04-14 6:04 ` Christoph Hellwig
2023-04-14 7:56 ` Ritesh Harjani
2023-04-14 13:06 ` Christoph Hellwig
2023-04-14 14:38 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jpizy3w.fsf@doe.com \
--to=ritesh.list@gmail.com \
--cc=disgoel@linux.ibm.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).