linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luis Henriques <luis.henriques@linux.dev>
To: Theodore Ts'o <tytso@mit.edu>,  Andreas Dilger <adilger@dilger.ca>
Cc: Jan Kara <jack@suse.cz>,
	 Harshad Shirwadkar <harshadshirwadkar@gmail.com>,
	 linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] ext4: fix fast commit inode enqueueing during a full journal commit
Date: Thu, 27 Jun 2024 14:54:39 +0100	[thread overview]
Message-ID: <875xtu7aow.fsf@brahms.olymp> (raw)
In-Reply-To: <20240529092030.9557-1-luis.henriques@linux.dev> (Luis Henriques's message of "Wed, 29 May 2024 10:20:28 +0100")

On Wed, May 29 2024, Luis Henriques (SUSE) wrote:

> Hi!
>
> Here's v3 of this fix to the fast commit enqueuing bug triggered by fstest
> generic/047.  This version simplifies the previous patch version by re-using
> the i_sync_tid field in struct ext4_inode_info instead of adding a new one.
>
> The extra patch includes a few extra fixes to the tid_t type handling.  Jan
> brought to my attention the fact that this sequence number may wrap, and I
> quickly found a few places in the code where the tid_geq() and tid_gt()
> helpers had to be used.
>
> Again, please note that this fix requires [1] to be applied too.
>
> [1] https://lore.kernel.org/all/20240515082857.32730-1-luis.henriques@linux.dev
>
> Luis Henriques (SUSE) (2):
>   ext4: fix fast commit inode enqueueing during a full journal commit
>   ext4: fix possible tid_t sequence overflows

Gentle ping...  Has this fell through the cracks?

Cheers,
-- 
Luis

>
> fs/ext4/fast_commit.c | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
>

  parent reply	other threads:[~2024-06-27 13:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-29  9:20 [PATCH v3 0/2] ext4: fix fast commit inode enqueueing during a full journal commit Luis Henriques (SUSE)
2024-05-29  9:20 ` [PATCH v3 1/2] " Luis Henriques (SUSE)
2024-05-29  9:50   ` Jan Kara
2024-05-29 16:52     ` harshad shirwadkar
2024-07-09  3:59   ` Theodore Ts'o
2024-07-09 14:39     ` Luis Henriques
2024-07-10 10:32       ` Luis Henriques
2024-05-29  9:20 ` [PATCH v3 2/2] ext4: fix possible tid_t sequence overflows Luis Henriques (SUSE)
2024-05-29  9:51   ` Jan Kara
2024-05-29 16:51     ` harshad shirwadkar
2024-06-27 13:54 ` Luis Henriques [this message]
2024-06-27 14:58   ` [PATCH v3 0/2] ext4: fix fast commit inode enqueueing during a full journal commit Theodore Ts'o
2024-06-27 15:10     ` Luis Henriques
2024-07-11  2:35 ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875xtu7aow.fsf@brahms.olymp \
    --to=luis.henriques@linux.dev \
    --cc=adilger@dilger.ca \
    --cc=harshadshirwadkar@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).