From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A311E194C68 for ; Thu, 27 Jun 2024 13:54:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.184 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719496486; cv=none; b=Paep9f6HbzmLqMyeEiRYqXtExwd4xR3O4EqAvfkNd75RgIMSxAWVHricU+vi+rt9foOhp5KiHsU+WcrzR8X3E6+p+21WvgNMqrZg1EzbWIjqph7wN0IjAQi/3gJmGx6TjoPJs2dLDNtJdCh9Ofo7TYHB3DO065Wgj0pIhK4X1vg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719496486; c=relaxed/simple; bh=b7bOhize7LEvUwKz4/795cSqj/Se2wduc6WO5bwEXZM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=nQGfJc0MZYZN1xBCGRCJtCuZebFEXYM5/9RMjxA++Am0rTAYhcenpF/3gPyQRqahGVdSHhe14v+IYJF28InE+eQsSCNGSH6MVpK7M9IJpDRO9vFnrCxNcCcoFMQBi62rZSWWXPF3lRyDiiX+kxS2uFipD0HKE7JuK0cXOTpNwC8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=R5U4/w5l; arc=none smtp.client-ip=91.218.175.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="R5U4/w5l" X-Envelope-To: tytso@mit.edu DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1719496482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nUwWST44U1/yKHahJYGe2+vcp0m8PSuGOix6qGydW4c=; b=R5U4/w5lxcTGkf3Bn96S2VWKdr9MGSRe1cudvwr489BNzoQde0gDKW4FVxMH4pWBmm7eo0 4CzaZpHajLyvglwC+ce81BfXRkEdVPOypLeXuZYzgHypF7y3XpPX3xUjCyL36J8eP+59Lh 4Kzbo2672QSldfK9eaTBkf8RlOef19o= X-Envelope-To: adilger@dilger.ca X-Envelope-To: jack@suse.cz X-Envelope-To: harshadshirwadkar@gmail.com X-Envelope-To: linux-ext4@vger.kernel.org X-Envelope-To: linux-kernel@vger.kernel.org X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Luis Henriques To: Theodore Ts'o , Andreas Dilger Cc: Jan Kara , Harshad Shirwadkar , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/2] ext4: fix fast commit inode enqueueing during a full journal commit In-Reply-To: <20240529092030.9557-1-luis.henriques@linux.dev> (Luis Henriques's message of "Wed, 29 May 2024 10:20:28 +0100") References: <20240529092030.9557-1-luis.henriques@linux.dev> Date: Thu, 27 Jun 2024 14:54:39 +0100 Message-ID: <875xtu7aow.fsf@brahms.olymp> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT On Wed, May 29 2024, Luis Henriques (SUSE) wrote: > Hi! > > Here's v3 of this fix to the fast commit enqueuing bug triggered by fstest > generic/047. This version simplifies the previous patch version by re-using > the i_sync_tid field in struct ext4_inode_info instead of adding a new one. > > The extra patch includes a few extra fixes to the tid_t type handling. Jan > brought to my attention the fact that this sequence number may wrap, and I > quickly found a few places in the code where the tid_geq() and tid_gt() > helpers had to be used. > > Again, please note that this fix requires [1] to be applied too. > > [1] https://lore.kernel.org/all/20240515082857.32730-1-luis.henriques@linux.dev > > Luis Henriques (SUSE) (2): > ext4: fix fast commit inode enqueueing during a full journal commit > ext4: fix possible tid_t sequence overflows Gentle ping... Has this fell through the cracks? Cheers, -- Luis > > fs/ext4/fast_commit.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) >