From: Dmitry Monakhov <dmonakhov@openvz.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: ext4_da_convert_inline_data_to_extent drop locked page after error
Date: Wed, 03 Dec 2014 11:20:12 +0300 [thread overview]
Message-ID: <877fy9du0z.fsf@openvz.org> (raw)
In-Reply-To: <20141202235913.GJ13618@thunk.org>
[-- Attachment #1: Type: text/plain, Size: 2587 bytes --]
Theodore Ts'o <tytso@mit.edu> writes:
> On Tue, Dec 02, 2014 at 06:28:20PM +0400, Dmitry Monakhov wrote:
>> Testcase:
>> xfstests generic/270
>> MKFS_OPTIONS="-q -I 256 -O inline_data,64bit"
>>
>> Call Trace:
>> [<ffffffff81144c76>] lock_page+0x35/0x39 -------> DEADLOCK
>> [<ffffffff81145260>] pagecache_get_page+0x65/0x15a
>> [<ffffffff811507fc>] truncate_inode_pages_range+0x1db/0x45c
>> [<ffffffff8120ea63>] ? ext4_da_get_block_prep+0x439/0x4b6
>> [<ffffffff811b29b7>] ? __block_write_begin+0x284/0x29c
>> [<ffffffff8120e62a>] ? ext4_change_inode_journal_flag+0x16b/0x16b
>> [<ffffffff81150af0>] truncate_inode_pages+0x12/0x14
>> [<ffffffff81247cb4>] ext4_truncate_failed_write+0x19/0x25
>> [<ffffffff812488cf>] ext4_da_write_inline_data_begin+0x196/0x31c
>> [<ffffffff81210dad>] ext4_da_write_begin+0x189/0x302
>> [<ffffffff810c07ac>] ? trace_hardirqs_on+0xd/0xf
>> [<ffffffff810ddd13>] ? read_seqcount_begin.clone.1+0x9f/0xcc
>> [<ffffffff8114309d>] generic_perform_write+0xc7/0x1c6
>> [<ffffffff810c040e>] ? mark_held_locks+0x59/0x77
>> [<ffffffff811445d1>] __generic_file_write_iter+0x17f/0x1c5
>> [<ffffffff8120726b>] ext4_file_write_iter+0x2a5/0x354
>> [<ffffffff81185656>] ? file_start_write+0x2a/0x2c
>> [<ffffffff8107bcdb>] ? bad_area_nosemaphore+0x13/0x15
>> [<ffffffff811858ce>] new_sync_write+0x8a/0xb2
>> [<ffffffff81186e7b>] vfs_write+0xb5/0x14d
>> [<ffffffff81186ffb>] SyS_write+0x5c/0x8c
>> [<ffffffff816f2529>] system_call_fastpath+0x12/0x17
>>
>> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
>
> This patch makes sense but I haven't been able to duplicate the
> failure. Maybe it's sensitive to the size of the scratch device, or
> some such?
I use xfstest-bld. So our test environment should be equals.
Unfortunately this is is not 100% reproducible, that is why I've missed
that bug on first test-run. Even more yesterday I've scheduled inline_data tests
to run for a whole night and it is deadlocked again in almost the same
place :)
[<ffffffff816f1698>] rwsem_down_write_failed+0x216/0x283 ->want xattr_sem -> DEADLOCK
[<ffffffff81414763>] call_rwsem_down_write_failed+0x13/0x20
[<ffffffff816f0eb3>] ? down_write+0x98/0xbc
[<ffffffff81249c9e>] ? ext4_inline_data_truncate+0x96/0x2c6
[<ffffffff81249c9e>] ext4_inline_data_truncate+0x96/0x2c6
[<ffffffff81210335>] ext4_truncate+0x171/0x432
[<ffffffff8124870c>] ext4_truncate_failed_write+0x21/0x25
[<ffffffff81249332>] ext4_da_write_inline_data_begin+0x1a9/0x33a ->holds xattr_sem
I'll send you updated version in a minute.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]
next prev parent reply other threads:[~2014-12-03 8:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 14:28 [PATCH] ext4: ext4_da_convert_inline_data_to_extent drop locked page after error Dmitry Monakhov
2014-12-02 23:59 ` Theodore Ts'o
2014-12-03 1:36 ` Theodore Ts'o
2014-12-03 8:20 ` Dmitry Monakhov [this message]
2014-12-03 13:54 ` [PATCH] ext4: ext4_da_convert_inline_data_to_extent drop locked page after error V2 Dmitry Monakhov
2014-12-03 14:31 ` [PATCH] ext4: ext4_da_convert_inline_data_to_extent drop locked page after error Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fy9du0z.fsf@openvz.org \
--to=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).