From: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
To: jing zhang <zj.barak@gmail.com>, tytso@mit.edu
Cc: linux-ext4 <linux-ext4@vger.kernel.org>,
Andreas Dilger <adilger@sun.com>,
Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Subject: Re: [PATCH] ext4: remove unnecessary operation in ext4_mb_regular_allocator()
Date: Wed, 24 Mar 2010 22:53:23 +0530 [thread overview]
Message-ID: <878w9hd46s.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <ac8f92701003230540w5a788ec1s54737e2e38c90e11@mail.gmail.com>
On Tue, 23 Mar 2010 20:40:29 +0800, jing zhang <zj.barak@gmail.com> wrote:
> 2010/3/23, tytso@mit.edu <tytso@mit.edu>:
> > On Mon, Mar 22, 2010 at 10:35:54PM +0800, jing zhang wrote:
> >> From: Jing Zhang <zj.barak@gmail.com>
> >>
> >> Date: Mon Mar 22 22:20:38 2010
> >>
> >> 1, In one of the hot functions in mballoc.c, unnecessary operation on
> >> struct ext4_group_desc *desc;
> >> is removed.
>
> ---
>
> diff --git a/linux-2.6.32/fs/ext4/mballoc.c b/ext4_mm_leak/mballoc5.c
> index bba1282..fb18199 100644
> --- a/linux-2.6.32/fs/ext4/mballoc.c
> +++ b/ext4_mm_leak/mballoc5.c
> @@ -2027,7 +2027,6 @@ repeat:
>
> for (i = 0; i < ngroups; group++, i++) {
> struct ext4_group_info *grp;
> - struct ext4_group_desc *desc;
>
> if (group == ngroups)
> group = 0;
> @@ -2050,7 +2049,6 @@ repeat:
> }
>
> ac->ac_groups_scanned++;
> - desc = ext4_get_group_desc(sb, group, NULL);
> if (cr == 0)
> ext4_mb_simple_scan_group(ac, &e4b);
> else if (cr == 1 &&
>
We missed that in commit 75507efb1372b6acf1aa6bf00ebd49ce196fd994
ealier we had an uninit check around that.
-aneesh
next prev parent reply other threads:[~2010-03-24 17:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 14:35 [PATCH] ext4: remove unnecessary operation in ext4_mb_regular_allocator() jing zhang
2010-03-22 18:26 ` tytso
2010-03-23 12:40 ` jing zhang
2010-03-23 16:56 ` tytso
2010-03-24 12:14 ` jing zhang
2010-04-02 1:48 ` [PATCH 1/2] ext4: Remove unnecessary call to ext4_get_group_desc() in mballoc Theodore Ts'o
2010-04-02 1:48 ` [PATCH 2/2] ext4: rename ext4_mb_release_desc() to ext4_mb_unload_buddy() Theodore Ts'o
2010-03-24 17:23 ` Aneesh Kumar K. V [this message]
2010-03-23 3:42 ` [PATCH] ext4: remove unnecessary operation in ext4_mb_regular_allocator() Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878w9hd46s.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=shaggy@linux.vnet.ibm.com \
--cc=tytso@mit.edu \
--cc=zj.barak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).