From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K. V" Subject: Re: [PATCH] ext4: remove unnecessary operation in ext4_mb_regular_allocator() Date: Wed, 24 Mar 2010 22:53:23 +0530 Message-ID: <878w9hd46s.fsf@linux.vnet.ibm.com> References: <20100322182645.GI11560@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-ext4 , Andreas Dilger , Dave Kleikamp To: jing zhang , tytso@mit.edu Return-path: Received: from e28smtp08.in.ibm.com ([122.248.162.8]:41049 "EHLO e28smtp08.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754964Ab0CXRX2 (ORCPT ); Wed, 24 Mar 2010 13:23:28 -0400 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by e28smtp08.in.ibm.com (8.14.3/8.13.1) with ESMTP id o2OGYXnF003646 for ; Wed, 24 Mar 2010 22:04:33 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o2OHNQwb3149940 for ; Wed, 24 Mar 2010 22:53:26 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o2OHNQKU012812 for ; Thu, 25 Mar 2010 04:23:26 +1100 In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Tue, 23 Mar 2010 20:40:29 +0800, jing zhang wrote: > 2010/3/23, tytso@mit.edu : > > On Mon, Mar 22, 2010 at 10:35:54PM +0800, jing zhang wrote: > >> From: Jing Zhang > >> > >> Date: Mon Mar 22 22:20:38 2010 > >> > >> 1, In one of the hot functions in mballoc.c, unnecessary operation on > >> struct ext4_group_desc *desc; > >> is removed. > > --- > > diff --git a/linux-2.6.32/fs/ext4/mballoc.c b/ext4_mm_leak/mballoc5.c > index bba1282..fb18199 100644 > --- a/linux-2.6.32/fs/ext4/mballoc.c > +++ b/ext4_mm_leak/mballoc5.c > @@ -2027,7 +2027,6 @@ repeat: > > for (i = 0; i < ngroups; group++, i++) { > struct ext4_group_info *grp; > - struct ext4_group_desc *desc; > > if (group == ngroups) > group = 0; > @@ -2050,7 +2049,6 @@ repeat: > } > > ac->ac_groups_scanned++; > - desc = ext4_get_group_desc(sb, group, NULL); > if (cr == 0) > ext4_mb_simple_scan_group(ac, &e4b); > else if (cr == 1 && > We missed that in commit 75507efb1372b6acf1aa6bf00ebd49ce196fd994 ealier we had an uninit check around that. -aneesh