Re: [PATCH v2 3/3] ovl: fix the parsing of empty string mount parameters

Miklos Szeredi
2024-03-11T09:25:33Z

On Thu, 7 Mar 2024 at 19:17, Luis Henriques <lhenriques@suse.de> wrote:
>
> This patch fixes the usage of mount parameters that are defined as strings
> but which can be empty. Currently, only 'lowerdir' parameter is in this
> situation for overlayfs. But since userspace can pass it in as 'flag'
> type (when it doesn't have a value), the parsing will fail because a
> 'string' type is assumed.

I don't really get why allowing a flag value instead of an empty
string value is fixing anything.

It just makes the API more liberal, but for what gain?

Thanks,
Miklos