From: Greg Freemyer <greg.freemyer@gmail.com>
To: Peng Tao <bergwolf@gmail.com>
Cc: Akira Fujita <a-fujita@rs.jp.nec.com>,
Theodore Tso <tytso@mit.edu>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/4]ext4: Return exchanged blocks count to user space in failure
Date: Wed, 2 Sep 2009 16:59:19 -0400 [thread overview]
Message-ID: <87f94c370909021359p171c6f6dte9b700cd48a5fde0@mail.gmail.com> (raw)
In-Reply-To: <4A9E9521.2010701@gmail.com>
On Wed, Sep 2, 2009 at 11:54 AM, Peng Tao<bergwolf@gmail.com> wrote:
> Hi, Akira,
>
> Akira Fujita wrote:
>> ext4: Return exchanged blocks count to user space in failure
>>
>> From: Akira Fujita <a-fujita@rs.jp.nec.com>
>>
>> Return exchanged blocks count (moved_len) to user space,
>> if ext4_move_extents() failed on the way.
> Even with the patch, I still don't see how users can fix EXT4_IOC_MOVE_EXT failures,
> because the orig file itself may be broken.
Peng,
I have not looked at the code very closely, but can you tell me where
a file corruption can take place? Not completing the replacement of
extents with donor extents is one thing. Corrupting the original file
contents is another.
Clearly we need EXT4_IOC_MOVE_EXT to fail gracefully and not corrupt
the original file the vast majority of the time.
Greg
next prev parent reply other threads:[~2009-09-02 20:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 3:18 [PATCH 3/4]ext4: Return exchanged blocks count to user space in failure Akira Fujita
2009-09-02 15:54 ` Peng Tao
2009-09-02 20:59 ` Greg Freemyer [this message]
2009-09-03 5:13 ` Peng Tao
2009-09-03 13:48 ` Greg Freemyer
2009-09-04 3:35 ` Peng Tao
2009-09-04 9:55 ` Akira Fujita
2009-09-04 16:43 ` Peng Tao
2009-09-08 4:11 ` Akira Fujita
2009-09-08 8:00 ` Peng Tao
2009-09-11 5:06 ` Akira Fujita
2009-09-11 5:28 ` Peng Tao
2009-09-11 16:57 ` Peng Tao
2009-09-14 6:16 ` Akira Fujita
2009-09-06 3:37 ` Theodore Tso
2009-09-06 3:13 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87f94c370909021359p171c6f6dte9b700cd48a5fde0@mail.gmail.com \
--to=greg.freemyer@gmail.com \
--cc=a-fujita@rs.jp.nec.com \
--cc=bergwolf@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).