From: Greg Freemyer <greg.freemyer@gmail.com>
To: Peng Tao <bergwolf@gmail.com>
Cc: linux-ext4@vger.kernel.org, Theodore Tso <tytso@mit.edu>,
Akira Fujita <a-fujita@rs.jp.nec.com>
Subject: Re: [PATCH] e4defrag: fallocate donor file only once
Date: Wed, 2 Sep 2009 18:09:39 -0400 [thread overview]
Message-ID: <87f94c370909021509u7d07a6e5ia210cfd8b8db70e0@mail.gmail.com> (raw)
In-Reply-To: <1251905704-10078-1-git-send-email-bergwolf@gmail.com>
On Wed, Sep 2, 2009 at 11:35 AM, Peng Tao<bergwolf@gmail.com> wrote:
> If we allocate the donor file once for all, it will have a better chance
> to be continuous.
>
> Signed-off-by: "Peng Tao" <bergwolf@gmail.com>
Seems like an improvement, but I'm not seeing any special handling for
sparse files. (Not before or after this patch.)
Seems like there should be an outer loop that identifies contiguous
data block sets in a sparse file and defrags them individually as
opposed to trying to defrag the entire file at once.
My impression is that with a large sparse file, e4defrag currently
(with or without this patch) would fallocate a full non-sparse donor
set of blocks the full size of the original file, then swap in just
the truly allocated blocks?
If so, that is not very optimum.
Greg
next prev parent reply other threads:[~2009-09-02 22:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 15:35 [PATCH] e4defrag: fallocate donor file only once Peng Tao
2009-09-02 22:09 ` Greg Freemyer [this message]
2009-09-02 22:24 ` Andreas Dilger
2009-09-03 8:00 ` Peng Tao
2009-09-03 9:30 ` Greg Freemyer
2009-09-04 3:08 ` Peng Tao
2009-09-04 12:36 ` Greg Freemyer
2009-09-04 16:56 ` Peng Tao
2009-09-04 19:10 ` Greg Freemyer
2009-09-05 16:29 ` Peng Tao
2009-09-08 15:41 ` Greg Freemyer
2009-09-09 1:24 ` Peng Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87f94c370909021509u7d07a6e5ia210cfd8b8db70e0@mail.gmail.com \
--to=greg.freemyer@gmail.com \
--cc=a-fujita@rs.jp.nec.com \
--cc=bergwolf@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).