From: Greg Freemyer <greg.freemyer@gmail.com>
To: Peng Tao <bergwolf@gmail.com>
Cc: Akira Fujita <a-fujita@rs.jp.nec.com>,
Theodore Tso <tytso@mit.edu>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/4]ext4: Return exchanged blocks count to user space in failure
Date: Thu, 3 Sep 2009 09:48:00 -0400 [thread overview]
Message-ID: <87f94c370909030648n84c5814kb04cb6d5e17b3d6e@mail.gmail.com> (raw)
In-Reply-To: <6149e97b0909022213p2b8463fdm796c8687d36ae54c@mail.gmail.com>
On Thu, Sep 3, 2009 at 1:13 AM, Peng Tao<bergwolf@gmail.com> wrote:
> Hi, Greg,
>
> On Thu, Sep 3, 2009 at 4:59 AM, Greg Freemyer<greg.freemyer@gmail.com> wrote:
>> Peng,
>>
>> I have not looked at the code very closely, but can you tell me where
>> a file corruption can take place? Not completing the replacement of
>> extents with donor extents is one thing. Corrupting the original file
>> contents is another.
> The file corruption is mainly because of the half done replacement.
>
> My test case is here:
> http://marc.info/?l=linux-ext4&m=124992522305319&w=2
>
> With Akira's previous patch
> (http://marc.info/?l=linux-ext4&m=124937430627867&w=2),
> EXT4_IOC_MOVE_EXT does not panic the kernel any more. But it leaves
> the orig file's extent tree corrupted.
Is this highly repeatable, e4defrag using EXT4_IOC_MOVE_EXT corrupts
sparse files?
If so, it seems like a pretty major bug that will be exposed to
userspace when 2.6.31 goes final.
It seems to me at a minimum a Kconfig option should be added to enable
the ioctl to userspace and that it should have depends on EXPERIMENTAL
and default to NO for now.
We don't want people thinking that this feature is stable in 2.6.31.
Greg
--
Greg Freemyer
Head of EDD Tape Extraction and Processing team
Litigation Triage Solutions Specialist
http://www.linkedin.com/in/gregfreemyer
Preservation and Forensic processing of Exchange Repositories White Paper -
<http://www.norcrossgroup.com/forms/whitepapers/tng_whitepaper_fpe.html>
The Norcross Group
The Intersection of Evidence & Technology
http://www.norcrossgroup.com
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-09-03 13:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 3:18 [PATCH 3/4]ext4: Return exchanged blocks count to user space in failure Akira Fujita
2009-09-02 15:54 ` Peng Tao
2009-09-02 20:59 ` Greg Freemyer
2009-09-03 5:13 ` Peng Tao
2009-09-03 13:48 ` Greg Freemyer [this message]
2009-09-04 3:35 ` Peng Tao
2009-09-04 9:55 ` Akira Fujita
2009-09-04 16:43 ` Peng Tao
2009-09-08 4:11 ` Akira Fujita
2009-09-08 8:00 ` Peng Tao
2009-09-11 5:06 ` Akira Fujita
2009-09-11 5:28 ` Peng Tao
2009-09-11 16:57 ` Peng Tao
2009-09-14 6:16 ` Akira Fujita
2009-09-06 3:37 ` Theodore Tso
2009-09-06 3:13 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87f94c370909030648n84c5814kb04cb6d5e17b3d6e@mail.gmail.com \
--to=greg.freemyer@gmail.com \
--cc=a-fujita@rs.jp.nec.com \
--cc=bergwolf@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).