Re: [PATCH v2 1/2] new: Add a new parameter (name/emailid) in the "new" script

[Ritesh Harjani (IBM) <ritesh.list@gmail.com>]

"Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com> writes:

> This patch another optional interactive prompt to enter the
> author name and email id for each new test file that is
> created using the "new" file.
>
> The sample output looks like something like the following:
>
> ./new selftest
> Next test id is 007
> Append a name to the ID? Test name will be 007-$name. y,[n]:
> Creating test file '007'
> Add to group(s) [auto] (separate by space, ? for list): selftest quick
> Enter <author_name> <email-id>: Nirjhar Roy <nirjhar.roy.lists@gmail.com>

I don't see much of a value add in this change here, as folks or
atleast I prefer to quickly get into writing my test first and later
worry about these details :). But I guess I understand where you are
coming from, a lot of times people miss to update this and end up
sending a test with "YOUR NAME HERE" placeholder.

So, sure if we are doing this - then please fix the commit message too,
as it still shows <email-id> above.

-ritesh

> Creating skeletal script for you to edit ...
>  done.
>
> ...
> ...
>
> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
> ---
>  new | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/new b/new
> index 6b50ffed..636648e2 100755
> --- a/new
> +++ b/new
> @@ -136,6 +136,9 @@ else
>  	check_groups "${new_groups[@]}" || exit 1
>  fi
>  
> +read -p "Enter <author_name>: " -r
> +author_name="${REPLY:=YOUR NAME HERE}"
> +
>  echo -n "Creating skeletal script for you to edit ..."
>  
>  year=`date +%Y`
> @@ -143,7 +146,7 @@ year=`date +%Y`
>  cat <<End-of-File >$tdir/$id
>  #! /bin/bash
>  # SPDX-License-Identifier: GPL-2.0
> -# Copyright (c) $year YOUR NAME HERE.  All Rights Reserved.
> +# Copyright (c) $year $author_name.  All Rights Reserved.
>  #
>  # FS QA Test $id
>  #
> -- 
> 2.34.1