From: Ritesh Harjani <ritesh.list@gmail.com>
To: Li kunyu <kunyu@nfschina.com>, tytso@mit.edu, adilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Li kunyu <kunyu@nfschina.com>
Subject: Re: [PATCH] ext4: ialloc: Remove variables defined more than once in a function
Date: Thu, 16 Feb 2023 18:26:07 +0530 [thread overview]
Message-ID: <87k00hn508.fsf@doe.com> (raw)
In-Reply-To: <20230207233632.4723-1-kunyu@nfschina.com>
Li kunyu <kunyu@nfschina.com> writes:
> The grp pointer variable has been defined at the beginning of the
> function. It is not necessary to define it here, so remove the variable
> definition here.
>
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
> fs/ext4/ialloc.c | 1 -
> 1 file changed, 1 deletion(-)
Looks good to me. Please feel free to add -
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
>
> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
> index 63f9bb6e8851..be9f742f9415 100644
> --- a/fs/ext4/ialloc.c
> +++ b/fs/ext4/ialloc.c
> @@ -1181,7 +1181,6 @@ struct inode *__ext4_new_inode(struct user_namespace *mnt_userns,
> /* Update the relevant bg descriptor fields */
> if (ext4_has_group_desc_csum(sb)) {
> int free;
> - struct ext4_group_info *grp = NULL;
>
> if (!(sbi->s_mount_state & EXT4_FC_REPLAY)) {
> grp = ext4_get_group_info(sb, group);
> --
> 2.18.2
prev parent reply other threads:[~2023-02-16 12:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 23:36 [PATCH] ext4: ialloc: Remove variables defined more than once in a function Li kunyu
2023-02-16 12:56 ` Ritesh Harjani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k00hn508.fsf@doe.com \
--to=ritesh.list@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=kunyu@nfschina.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).