From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>, John Garry <john.g.garry@oracle.com>
Cc: linux-ext4@vger.kernel.org, Jan Kara <jack@suse.cz>,
djwong@kernel.org, Ojaswin Mujoo <ojaswin@linux.ibm.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v5 7/7] ext4: Add atomic block write documentation
Date: Fri, 16 May 2025 20:06:43 +0530 [thread overview]
Message-ID: <87ldqwwrk4.fsf@gmail.com> (raw)
In-Reply-To: <20250516121938.GA7158@mit.edu>
"Theodore Ts'o" <tytso@mit.edu> writes:
> On Fri, May 16, 2025 at 09:55:09AM +0100, John Garry wrote:
>>
>> Or move this file to a common location, and have separate sections for ext4
>> and xfs? This would save having scattered files for instructions.
>
> What is the current outook for the xfs changes landing in the next
> merge window? I haven't been tracking the latest rounds of reviews
> for the xfs atomic writes patchset.
>
> If the xfs atomic writes patchset aren't going to land this window,
> then we can land them as ext4 specific documentation, and when the xfs
> patches land, we can reorganize the documentation at that point. Does
> that make sense?
>
IMO, the current documentation is primarily intended to capture notes
from ext4's implementation perspective of single and multi-fsblock
atomic writes.
I guess adding a more general atomic write documentation require a lot
of other grounds to cover too e.g.
- block device driver support (scsi & nvme, dm-... )
- block layer support (bio split & merge )
- Filesystem & iomap support (iomap, ext4, xfs)
- VFS layer support (statx, pwritev2...)
So, IMO, even with XFS atomic writes patches queued for v6.16, the
current documentation still stands correct. To cover more ground around
atomic writes detail, we can think of adding a common documentation
later which can refer to individual filesystem's documentation file for
implementation notes.
Thoughts?
-ritesh
next prev parent reply other threads:[~2025-05-16 14:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 19:50 [PATCH v5 0/7] ext4: Add multi-fsblock atomic write support with bigalloc Ritesh Harjani (IBM)
2025-05-15 19:50 ` [PATCH v5 1/7] ext4: Document an edge case for overwrites Ritesh Harjani (IBM)
2025-05-15 19:50 ` [PATCH v5 2/7] ext4: Check if inode uses extents in ext4_inode_can_atomic_write() Ritesh Harjani (IBM)
2025-05-15 19:50 ` [PATCH v5 3/7] ext4: Make ext4_meta_trans_blocks() non-static for later use Ritesh Harjani (IBM)
2025-05-15 19:50 ` [PATCH v5 4/7] ext4: Add support for EXT4_GET_BLOCKS_QUERY_LEAF_BLOCKS Ritesh Harjani (IBM)
2025-05-15 19:50 ` [PATCH v5 5/7] ext4: Add multi-fsblock atomic write support with bigalloc Ritesh Harjani (IBM)
2025-05-15 19:50 ` [PATCH v5 6/7] ext4: Enable support for ext4 multi-fsblock atomic write using bigalloc Ritesh Harjani (IBM)
2025-05-15 19:50 ` [PATCH v5 7/7] ext4: Add atomic block write documentation Ritesh Harjani (IBM)
2025-05-16 8:55 ` John Garry
2025-05-16 12:19 ` Theodore Ts'o
2025-05-16 13:05 ` John Garry
2025-05-16 13:31 ` Carlos Maiolino
2025-05-16 14:48 ` Theodore Ts'o
2025-05-16 15:10 ` Darrick J. Wong
2025-05-16 18:13 ` Carlos Maiolino
2025-05-16 14:36 ` Ritesh Harjani [this message]
2025-05-16 14:15 ` Ritesh Harjani
2025-05-19 10:07 ` [PATCH v5 0/7] ext4: Add multi-fsblock atomic write support with bigalloc Ritesh Harjani
2025-05-19 15:47 ` Theodore Ts'o
2025-05-20 14:40 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldqwwrk4.fsf@gmail.com \
--to=ritesh.list@gmail.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=john.g.garry@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox