From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04B82C4338F for ; Mon, 23 Aug 2021 14:35:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCCD1613CD for ; Mon, 23 Aug 2021 14:35:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230141AbhHWOfm (ORCPT ); Mon, 23 Aug 2021 10:35:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229726AbhHWOfm (ORCPT ); Mon, 23 Aug 2021 10:35:42 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9521C061575 for ; Mon, 23 Aug 2021 07:34:59 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 09EA31F41FB9 From: Gabriel Krisman Bertazi To: Matthew Bobrowski Cc: pvorel@suse.cz, Amir Goldstein , kernel@collabora.com, Khazhismel Kumykov , Jan Kara , Ext4 , LTP List Subject: Re: [LTP] [PATCH 3/7] syscalls/fanotify20: Validate incoming FID in FAN_FS_ERROR Organization: Collabora References: <20210802214645.2633028-1-krisman@collabora.com> <20210802214645.2633028-4-krisman@collabora.com> <87fsvphksu.fsf@collabora.com> Date: Mon, 23 Aug 2021 10:34:54 -0400 In-Reply-To: (Matthew Bobrowski's message of "Sat, 21 Aug 2021 07:58:07 +1000") Message-ID: <87o89o2prl.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Matthew Bobrowski writes: > Hey Gabriel, > > On Fri, Aug 20, 2021 at 12:21:19PM +0200, Petr Vorel wrote: >> Hi all, >> >> > No problem. That's what review is for ;-) >> >> > BTW, unless anyone is specifically interested I don't think there >> > is a reason to re post the test patches before the submission request. >> > Certainly not for the small fixes that I requested. >> >> > I do request that you post a link to a branch with the fixed test >> > so that we can experiment with the kernel patches. >> >> > I've also CC'ed Matthew who may want to help with review of the test >> > and man page that you posted in the cover letter [1]. >> >> @Amir Thanks a lot for your review, agree with all you mentioned. >> >> @Gabriel Thanks for your contribution. I'd also consider squashing some of the >> commits. > > Is the FAN_FS_ERROR feature to be included within the 5.15 release? If so, > I may need to do some shuffling around as these LTP tests collide with the > ones I author for the FAN_REPORT_PIDFD series. > Matthew, Hi, sorry for the delay. I took a short vacation and couldn't follow up. I think it is too late for 5.15, please go ahead with FAN_REPORT_PIDFD series and I will consider them in my future submission. Thank you, -- Gabriel Krisman Bertazi