From: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>, linux-ext4@vger.kernel.org
Cc: tytso@mit.edu, Dmitry Monakhov <dmonakhov@openvz.org>
Subject: Re: [PATCH] ext4: Do not zeroout uninitialized extents beyond i_size
Date: Wed, 28 Apr 2010 10:10:09 +0530 [thread overview]
Message-ID: <87och49oly.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1270833748-14381-1-git-send-email-dmonakhov@openvz.org>
On Fri, 9 Apr 2010 21:22:28 +0400, Dmitry Monakhov <dmonakhov@openvz.org> wrote:
> Zerrout trick allow us to optimize cases where it is more reasonable
> to explicitly zeroout extent and mark it as initialized instead of
> splitting to several small ones.
> But this optimization is not acceptable is extent is beyond i_size
> Because it is not possible to have initialized blocks after i_size.
> Fsck treat this as incorrect inode size.
>
With commit c8d46e41bc744c8fa0092112af3942fcd46c8b18 if we set
EXT4_EOFBLOCKS_FL we should be able to have blocks beyond i_size.
May be the zero out path should set the flag instead of doing all these
changes. Zero-out is already complex with all the ENOSPC related
consideration. I guess we should try to keep it simple.
-aneesh
next prev parent reply other threads:[~2010-04-28 4:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 17:22 [PATCH] ext4: Do not zeroout uninitialized extents beyond i_size Dmitry Monakhov
2010-04-14 21:28 ` tytso
2010-04-15 9:20 ` Dmitry Monakhov
2010-04-21 17:45 ` tytso
2010-04-28 4:40 ` Aneesh Kumar K. V [this message]
2010-04-28 7:38 ` Dmitry Monakhov
2010-05-27 17:19 ` Aneesh Kumar K. V
2010-06-03 8:32 ` Dmitry Monakhov
2010-06-08 21:46 ` tytso
-- strict thread matches above, loose matches on Subject: below --
2010-04-09 17:14 Dmitry Monakhov
2010-04-09 17:18 ` Dmitry Monakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87och49oly.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).