linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: "Darrick J. Wong" <djwong@kernel.org>,
	John Garry <john.g.garry@oracle.com>,
	brauner@kernel.org, Catherine Hoang <catherine.hoang@oracle.com>
Cc: linux-ext4@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
	Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@infradead.org>,
	Ojaswin Mujoo <ojaswin@linux.ibm.com>,
	linux-block@vger.kernel.org, Dave Chinner <david@fromorbit.com>,
	linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [ANNOUNCE] work tree for untorn filesystem writes
Date: Tue, 05 Nov 2024 21:56:45 +0530	[thread overview]
Message-ID: <87pln9sl2y.fsf@gmail.com> (raw)
In-Reply-To: <20241105004341.GO21836@frogsfrogsfrogs>

"Darrick J. Wong" <djwong@kernel.org> writes:

> Hi everyone,
>
> Nobody else has stepped up to do this, so I've created a work branch for
> the fs side of untorn writes:
> https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/log/?h=fs-atomic_2024-11-04
>
> Can you all check this to make sure that I merged it correctly?

Sorry, I couldn't reply earlier(I am currently on travel). Yes, the ext4
merge looks correct to me. You have taken the latest v4 of the ext4
atomic write series [1]. 

[1]: https://lore.kernel.org/linux-ext4/cover.1730437365.git.ritesh.list@gmail.com/

> And maybe go test this on your storage hardware? :)

Due to limited connectivity during my travel, I don't have the access to
the hardware. But as I mentioned the merge looks correct to me and I had
tested those patches earlier on Power and x86.
But I will in general re-test the mentioned fs branch for both XFS and
ext4 once I reach back but I don't think we need to wait for that as the
merge looks good to me.

Also, I noticed that we might have missed to add a Tested-by from
Ojaswin for XFS series here [2]. Although Ojaswin mentioned that he
might also re-test the mentioned FS atomic write branch for both XFS and
EXT4.

[2]: https://lore.kernel.org/linux-xfs/Zxnp8bma2KrMDg5m@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com/


-ritesh

> If all goes well then I think the next step is to ask brauner very
> nicely if he'd consider adding this to the vfs trees for 6.13.  If not
> then I guess we can submit it ourselves, though we probably ought to ask
> rothwell to add the branch to for-next asap.
>
> PS: We're now past -rc6 so please reply quickly so that this doesn't
> slip yet another cycle.
>
> Catherine: John's on vacation all week, could you please send me the
> latest versions of the xfs_io pwrite-atomic patch and the fstest for it?
>
> --D

      parent reply	other threads:[~2024-11-05 16:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-05  0:43 [ANNOUNCE] work tree for untorn filesystem writes Darrick J. Wong
2024-11-05 11:19 ` Carlos Maiolino
2024-11-05 12:52   ` Jens Axboe
2024-11-05 15:08     ` Theodore Ts'o
2024-11-05 15:11       ` Jens Axboe
2024-11-05 15:40         ` Darrick J. Wong
2024-11-05 15:54           ` Jens Axboe
2024-11-06 10:40             ` Christian Brauner
2024-11-07 13:38               ` Carlos Maiolino
2024-11-05 16:26 ` Ritesh Harjani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pln9sl2y.fsf@gmail.com \
    --to=ritesh.list@gmail.com \
    --cc=brauner@kernel.org \
    --cc=catherine.hoang@oracle.com \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=john.g.garry@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=ojaswin@linux.ibm.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).