From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: Kemeng Shi <shikemeng@huaweicloud.com>,
tytso@mit.edu, adilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
shikemeng@huaweicloud.com
Subject: Re: [PATCH 1/2] ext4: fix typos in mballoc
Date: Mon, 13 Mar 2023 07:42:56 +0530 [thread overview]
Message-ID: <87sfe9flg7.fsf@doe.com> (raw)
In-Reply-To: <20230311170949.1047958-2-shikemeng@huaweicloud.com>
Kemeng Shi <shikemeng@huaweicloud.com> writes:
> pa_plen -> pa_len
> pa_start -> pa_pstart
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
> ---
> fs/ext4/mballoc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Looks good to me. Please feel free to add -
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
>
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 85d5e219933f..13dce6f07fa4 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -4146,7 +4146,7 @@ ext4_mb_normalize_request(struct ext4_allocation_context *ac,
> * provide gurantee on number of contiguous blocks allocation since that
> * depends upon free space left, etc).
> * In case of inode pa, later we use the allocated blocks
> - * [pa_start + fe_logical - pa_lstart, fe_len/size] from the preallocated
> + * [pa_pstart + fe_logical - pa_lstart, fe_len/size] from the preallocated
> * range of goal/best blocks [start, size] to put it at the
> * ac_o_ex.fe_logical extent of this inode.
> * (See ext4_mb_use_inode_pa() for more details)
> @@ -4298,7 +4298,7 @@ static void ext4_mb_use_group_pa(struct ext4_allocation_context *ac,
> ac->ac_status = AC_STATUS_FOUND;
> ac->ac_pa = pa;
>
> - /* we don't correct pa_pstart or pa_plen here to avoid
> + /* we don't correct pa_pstart or pa_len here to avoid
> * possible race when the group is being loaded concurrently
> * instead we correct pa later, after blocks are marked
> * in on-disk bitmap -- see ext4_mb_release_context()
> --
> 2.30.0
next prev parent reply other threads:[~2023-03-13 2:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 17:09 [PATCH 0/2] two cleanups for mballoc Kemeng Shi
2023-03-11 17:09 ` [PATCH 1/2] ext4: fix typos in mballoc Kemeng Shi
2023-03-13 2:12 ` Ritesh Harjani [this message]
2023-03-11 17:09 ` [PATCH 2/2] ext4: avoid unnecessary pointer dereference in ext4_mb_normalize_request Kemeng Shi
2023-03-13 2:13 ` Ritesh Harjani
2023-03-17 1:52 ` [PATCH 0/2] two cleanups for mballoc Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfe9flg7.fsf@doe.com \
--to=ritesh.list@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shikemeng@huaweicloud.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).