* [PATCH] ext4: Minor fix for ext4_split_extent_zeroout()
@ 2026-02-06 15:58 Ojaswin Mujoo
2026-02-17 5:33 ` Ritesh Harjani
0 siblings, 1 reply; 3+ messages in thread
From: Ojaswin Mujoo @ 2026-02-06 15:58 UTC (permalink / raw)
To: linux-ext4, Theodore Ts'o; +Cc: Dan Carpenter
We missed storing the error which triggerd smatch warning:
fs/ext4/extents.c:3369 ext4_split_extent_zeroout()
warn: duplicate zero check 'err' (previous on line 3363)
fs/ext4/extents.c
3361
3362 err = ext4_ext_get_access(handle, inode, path + depth);
3363 if (err)
3364 return err;
3365
3366 ext4_ext_mark_initialized(ex);
3367
3368 ext4_ext_dirty(handle, inode, path + depth);
--> 3369 if (err)
3370 return err;
3371
3372 return 0;
3373 }
Fix it by correctly storing the err value from ext4_ext_dirty().
Link: https://lore.kernel.org/all/aYXvVgPnKltX79KE@stanley.mountain/
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
---
fs/ext4/extents.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 3630b27e4fd7..5579e0e68c0f 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3365,7 +3365,7 @@ static int ext4_split_extent_zeroout(handle_t *handle, struct inode *inode,
ext4_ext_mark_initialized(ex);
- ext4_ext_dirty(handle, inode, path + depth);
+ err = ext4_ext_dirty(handle, inode, path + depth);
if (err)
return err;
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: Minor fix for ext4_split_extent_zeroout()
2026-02-06 15:58 [PATCH] ext4: Minor fix for ext4_split_extent_zeroout() Ojaswin Mujoo
@ 2026-02-17 5:33 ` Ritesh Harjani
2026-03-02 14:30 ` Ojaswin Mujoo
0 siblings, 1 reply; 3+ messages in thread
From: Ritesh Harjani @ 2026-02-17 5:33 UTC (permalink / raw)
To: Ojaswin Mujoo, linux-ext4, Theodore Ts'o; +Cc: Dan Carpenter
Ojaswin Mujoo <ojaswin@linux.ibm.com> writes:
> We missed storing the error which triggerd smatch warning:
>
> fs/ext4/extents.c:3369 ext4_split_extent_zeroout()
> warn: duplicate zero check 'err' (previous on line 3363)
>
> fs/ext4/extents.c
> 3361
> 3362 err = ext4_ext_get_access(handle, inode, path + depth);
> 3363 if (err)
> 3364 return err;
> 3365
> 3366 ext4_ext_mark_initialized(ex);
> 3367
> 3368 ext4_ext_dirty(handle, inode, path + depth);
> --> 3369 if (err)
> 3370 return err;
> 3371
> 3372 return 0;
> 3373 }
>
> Fix it by correctly storing the err value from ext4_ext_dirty().
>
Looks straight forward.
> Link: https://lore.kernel.org/all/aYXvVgPnKltX79KE@stanley.mountain/
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Fixes: a985e07c26455 ("ext4: refactor zeroout path and handle all cases")
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
> ---
> fs/ext4/extents.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 3630b27e4fd7..5579e0e68c0f 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -3365,7 +3365,7 @@ static int ext4_split_extent_zeroout(handle_t *handle, struct inode *inode,
>
> ext4_ext_mark_initialized(ex);
>
> - ext4_ext_dirty(handle, inode, path + depth);
> + err = ext4_ext_dirty(handle, inode, path + depth);
> if (err)
> return err;
>
> --
> 2.52.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: Minor fix for ext4_split_extent_zeroout()
2026-02-17 5:33 ` Ritesh Harjani
@ 2026-03-02 14:30 ` Ojaswin Mujoo
0 siblings, 0 replies; 3+ messages in thread
From: Ojaswin Mujoo @ 2026-03-02 14:30 UTC (permalink / raw)
To: Ritesh Harjani; +Cc: linux-ext4, Theodore Ts'o, Dan Carpenter
On Tue, Feb 17, 2026 at 11:03:53AM +0530, Ritesh Harjani wrote:
> Ojaswin Mujoo <ojaswin@linux.ibm.com> writes:
>
> > We missed storing the error which triggerd smatch warning:
> >
> > fs/ext4/extents.c:3369 ext4_split_extent_zeroout()
> > warn: duplicate zero check 'err' (previous on line 3363)
> >
> > fs/ext4/extents.c
> > 3361
> > 3362 err = ext4_ext_get_access(handle, inode, path + depth);
> > 3363 if (err)
> > 3364 return err;
> > 3365
> > 3366 ext4_ext_mark_initialized(ex);
> > 3367
> > 3368 ext4_ext_dirty(handle, inode, path + depth);
> > --> 3369 if (err)
> > 3370 return err;
> > 3371
> > 3372 return 0;
> > 3373 }
> >
> > Fix it by correctly storing the err value from ext4_ext_dirty().
> >
>
>
> Looks straight forward.
>
>
> > Link: https://lore.kernel.org/all/aYXvVgPnKltX79KE@stanley.mountain/
> > Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> > Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
>
> Fixes: a985e07c26455 ("ext4: refactor zeroout path and handle all cases")
>
> Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Thanks Ritesh, I'll add the fixes tag and resend.
Regards,
ojaswin
>
>
> > ---
> > fs/ext4/extents.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> > index 3630b27e4fd7..5579e0e68c0f 100644
> > --- a/fs/ext4/extents.c
> > +++ b/fs/ext4/extents.c
> > @@ -3365,7 +3365,7 @@ static int ext4_split_extent_zeroout(handle_t *handle, struct inode *inode,
> >
> > ext4_ext_mark_initialized(ex);
> >
> > - ext4_ext_dirty(handle, inode, path + depth);
> > + err = ext4_ext_dirty(handle, inode, path + depth);
> > if (err)
> > return err;
> >
> > --
> > 2.52.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-02 14:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-06 15:58 [PATCH] ext4: Minor fix for ext4_split_extent_zeroout() Ojaswin Mujoo
2026-02-17 5:33 ` Ritesh Harjani
2026-03-02 14:30 ` Ojaswin Mujoo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox