From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com>,
fstests@vger.kernel.org
Cc: linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
ojaswin@linux.ibm.com, djwong@kernel.org, zlang@kernel.org,
david@fromorbit.com, nirjhar.roy.lists@gmail.com
Subject: Re: [PATCH v2 1/5] generic/749: Remove redundant sourcing of common/rc
Date: Fri, 04 Apr 2025 09:01:48 +0530 [thread overview]
Message-ID: <87tt74vbyz.fsf@gmail.com> (raw)
In-Reply-To: <b44393e0f3d6fce937058525bf5726421f7ca576.1743487913.git.nirjhar.roy.lists@gmail.com>
"Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com> writes:
> common/rc is already sourced before the test starts running
> in _begin_fstest() preamble.
Indeed. The patch looks good to me.
Feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
>
> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
> ---
> tests/generic/749 | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/generic/749 b/tests/generic/749
> index fc747738..451f283e 100755
> --- a/tests/generic/749
> +++ b/tests/generic/749
> @@ -15,7 +15,6 @@
> # boundary and ensures we get a SIGBUS if we write to data beyond the system
> # page size even if the block size is greater than the system page size.
> . ./common/preamble
> -. ./common/rc
> _begin_fstest auto quick prealloc
>
> # Import common functions.
> --
> 2.34.1
next prev parent reply other threads:[~2025-04-04 3:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 6:43 [PATCH v2 0/5] Minor cleanups in common/ Nirjhar Roy (IBM)
2025-04-01 6:43 ` [PATCH v2 1/5] generic/749: Remove redundant sourcing of common/rc Nirjhar Roy (IBM)
2025-04-04 3:31 ` Ritesh Harjani [this message]
2025-04-01 6:43 ` [PATCH v2 2/5] check: Remove redundant _test_mount in check Nirjhar Roy (IBM)
2025-04-04 3:36 ` Ritesh Harjani
2025-04-08 5:41 ` Nirjhar Roy (IBM)
2025-04-08 5:45 ` Nirjhar Roy (IBM)
2025-04-01 6:43 ` [PATCH v2 3/5] check,common{rc,preamble}: Decouple init_rc() call from sourcing common/rc Nirjhar Roy (IBM)
2025-04-04 4:00 ` Ritesh Harjani
2025-04-04 4:52 ` Nirjhar Roy (IBM)
2025-04-08 5:42 ` Nirjhar Roy (IBM)
2025-04-01 6:43 ` [PATCH v2 4/5] common/config: Introduce _exit wrapper around exit command Nirjhar Roy (IBM)
2025-04-04 5:03 ` Ritesh Harjani
2025-04-01 6:44 ` [PATCH v2 5/5] common: exit --> _exit Nirjhar Roy (IBM)
2025-04-04 5:04 ` Ritesh Harjani
2025-04-07 16:19 ` Zorro Lang
2025-04-07 18:46 ` Ritesh Harjani
2025-04-07 19:12 ` Darrick J. Wong
2025-04-07 19:19 ` Nirjhar Roy (IBM)
2025-04-07 19:13 ` Nirjhar Roy (IBM)
2025-04-08 14:27 ` Zorro Lang
2025-04-08 14:33 ` Darrick J. Wong
2025-04-08 16:25 ` Nirjhar Roy (IBM)
2025-04-07 18:59 ` Nirjhar Roy (IBM)
2025-04-01 21:37 ` [PATCH v2 0/5] Minor cleanups in common/ Dave Chinner
2025-04-04 14:31 ` Nirjhar Roy (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tt74vbyz.fsf@gmail.com \
--to=ritesh.list@gmail.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nirjhar.roy.lists@gmail.com \
--cc=ojaswin@linux.ibm.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox