From: Luis Henriques <luis.henriques@linux.dev>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Wang Jianjian <wangjianjian0@foxmail.com>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 2/2] ext4: Add correct group descriptors and reserved GDT blocks to system zone
Date: Mon, 01 Apr 2024 15:23:52 +0100 [thread overview]
Message-ID: <87ttkl6u13.fsf@brahms.olymp> (raw)
In-Reply-To: <20230817170557.GA3435781@mit.edu> (Theodore Ts'o's message of "Thu, 17 Aug 2023 13:05:57 -0400")
"Theodore Ts'o" <tytso@mit.edu> writes:
> On Thu, Aug 03, 2023 at 12:28:40AM +0800, Wang Jianjian wrote:
>> When setup_system_zone, flex_bg is not initialzied so it is always 1.
>> ext4_num_base_meta_blocks() returns the meta blocks in this group
>> including reserved GDT blocks, so let's use this helper.
>>
>> Signed-off-by: Wang Jianjian <wangjianjian0@foxmail.com>
>
> Thanks for the patch. I ended up collapsing the two patches into a
> single one, and then fixed up some checkpatch errors.
Sorry for revisiting this old thread, but it looks like these patches
(commit 68228da51c9a "ext4: add correct group descriptors and reserved GDT
blocks to system zone") broke fstest ext4/059.
A (very!) quick look seems to show that it's related with the very fact
that sbi->s_es->s_reserved_gdt_blocks are now taken into account to
compute the number of blocks (which is the point of the patch, of course).
Maybe the test needs to be fixed, as it messes up with the GDT reserved
blocks...?
Cheers,
--
Luis
next prev parent reply other threads:[~2024-04-01 14:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230802162840.331385-1-wangjianjian0@foxmail.com>
2023-08-02 16:28 ` [PATCH 2/2] ext4: Add correct group descriptors and reserved GDT blocks to system zone Wang Jianjian
2023-08-16 15:27 ` Wang Jianjian
2023-08-17 17:05 ` Theodore Ts'o
2024-04-01 14:23 ` Luis Henriques [this message]
2024-04-07 10:13 ` wangjianjian (C)
2024-04-10 8:36 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttkl6u13.fsf@brahms.olymp \
--to=luis.henriques@linux.dev \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=wangjianjian0@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).