* Tuxera test suite failure for setfacl
@ 2014-02-05 6:15 Aneesh Kumar K.V
2014-02-05 20:08 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Aneesh Kumar K.V @ 2014-02-05 6:15 UTC (permalink / raw)
To: Jan Kara, ext4 development
Hello,
With commit c6ac12a6159c802ae8b757dd13563564e64333df we are modifying
the ctime of the file when changing file's permission by setfacl. The
commit says that is correct as per spec. But we do have a test in tuxera
http://tuxera.com/sw/qa/pjd-fstest-20090130-RC.tgz test/xacl/00.t 45
which expect the ctime to be not changed across setfacl.
I haven't looked at the spec myself. Can you double check and make sure
it is ok to change the ctime across setfacl ?
-aneesh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Tuxera test suite failure for setfacl
2014-02-05 6:15 Tuxera test suite failure for setfacl Aneesh Kumar K.V
@ 2014-02-05 20:08 ` Jan Kara
2014-02-06 12:49 ` Aneesh Kumar K.V
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2014-02-05 20:08 UTC (permalink / raw)
To: Aneesh Kumar K.V; +Cc: Jan Kara, ext4 development
Hello,
On Wed 05-02-14 11:45:39, Aneesh Kumar K.V wrote:
> With commit c6ac12a6159c802ae8b757dd13563564e64333df we are modifying
> the ctime of the file when changing file's permission by setfacl. The
> commit says that is correct as per spec. But we do have a test in tuxera
> http://tuxera.com/sw/qa/pjd-fstest-20090130-RC.tgz test/xacl/00.t 45
> which expect the ctime to be not changed across setfacl.
>
> I haven't looked at the spec myself. Can you double check and make sure
> it is ok to change the ctime across setfacl ?
Well, it would be really strange if changing permissions via chmod(1)
changed ctime but via setfacl(1) did not, don't you think?
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Tuxera test suite failure for setfacl
2014-02-05 20:08 ` Jan Kara
@ 2014-02-06 12:49 ` Aneesh Kumar K.V
0 siblings, 0 replies; 3+ messages in thread
From: Aneesh Kumar K.V @ 2014-02-06 12:49 UTC (permalink / raw)
To: Jan Kara; +Cc: Jan Kara, ext4 development
Jan Kara <jack@suse.cz> writes:
> Hello,
>
> On Wed 05-02-14 11:45:39, Aneesh Kumar K.V wrote:
>> With commit c6ac12a6159c802ae8b757dd13563564e64333df we are modifying
>> the ctime of the file when changing file's permission by setfacl. The
>> commit says that is correct as per spec. But we do have a test in tuxera
>> http://tuxera.com/sw/qa/pjd-fstest-20090130-RC.tgz test/xacl/00.t 45
>> which expect the ctime to be not changed across setfacl.
>>
>> I haven't looked at the spec myself. Can you double check and make sure
>> it is ok to change the ctime across setfacl ?
> Well, it would be really strange if changing permissions via chmod(1)
> changed ctime but via setfacl(1) did not, don't you think?
>
That make sense. I guess we should consider this a test case error.
-aneesh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-06 12:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-05 6:15 Tuxera test suite failure for setfacl Aneesh Kumar K.V
2014-02-05 20:08 ` Jan Kara
2014-02-06 12:49 ` Aneesh Kumar K.V
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).