Re: [PATCH] e2fsprogs: Introduce script used to generate utf8data.h

[Gabriel Krisman Bertazi <krisman@collabora.com>]

"Theodore Y. Ts'o" <tytso@mit.edu> writes:

> On Mon, Dec 03, 2018 at 06:04:28PM -0500, Gabriel Krisman Bertazi wrote:
>> The mkutf8data program was written by SGI for the kernel. We integrate
>> it here, but it should be kept in sync with the kernel code, when
>> applicable.  The header generated by this script is also included in
>> this repository, such that we don't have to carry the UCD files too.
>> They are only necessary when the header has to be recreated (for
>> instance, to update the Unicode version supported)
>> 
>> The mkutf8data is not a dependency of utf8data.h because we don't want
>> the utf8data.h rule to be called after a make clean that would remove
>> mkutf8data.  It is simpler to call it from inside the rule, and make
>> sure we only trigger the utf8data.h rule if we really need to,
>> particularly if we decide not to integrate the ucd files in the tree.
>> 
>> The UCD files are not distributed along with this commit, but we add
>> information on how to fetch them.
>> 
>> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
>
> Thanks, applied, with one minor fixup:
>
>> diff --git a/util/ucd/README b/util/ucd/README
>> new file mode 100644
>> index 000000000000..9fed514084b7
>> --- /dev/null
>> +++ b/util/ucd/README
> ...
>> +md5sums
>> +
>> +  414436796cf097df55f798e1585448ee  CaseFolding-11.0.0.txt
>> +  6032a595fbb782694456491d86eecfac  DerivedAge-11.0.0.txt
>> +  3240997d671297ac754ab0d27577acf7  DerivedCombiningClass-11.0.0.txt
>> +  d41d8cd98f00b204e9800998ecf8427e  DerivedCombiningClass.txt
>                                        ^^^^^^^^^^^^^^^^^^^^^^^^^
>
> This looks like a leftover, so I removed it.

Indeed.

Thanks for applying.


-- 
Gabriel Krisman Bertazi