From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com>,
fstests@vger.kernel.org
Cc: linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
ojaswin@linux.ibm.com, djwong@kernel.org, zlang@kernel.org,
david@fromorbit.com, nirjhar.roy.lists@gmail.com
Subject: Re: [PATCH v3 2/6] generic/367: Remove redundant sourcing if common/config
Date: Tue, 08 Apr 2025 14:36:53 +0530 [thread overview]
Message-ID: <87zfgrja36.fsf@gmail.com> (raw)
In-Reply-To: <ffefbe485f71206dd2a0a27256d1101d2b0c7a64.1744090313.git.nirjhar.roy.lists@gmail.com>
"Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com> writes:
> common/config will be source by _begin_fstest
>
Looks good to me. Please feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
> ---
> tests/generic/367 | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/generic/367 b/tests/generic/367
> index ed371a02..567db557 100755
> --- a/tests/generic/367
> +++ b/tests/generic/367
> @@ -11,7 +11,6 @@
> # check if the extsize value and the xflag bit actually got reflected after
> # setting/re-setting the extsize value.
>
> -. ./common/config
> . ./common/filter
> . ./common/preamble
>
> --
> 2.34.1
next prev parent reply other threads:[~2025-04-08 9:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 5:37 [PATCH v3 0/6] Minor cleanups in common/ Nirjhar Roy (IBM)
2025-04-08 5:37 ` [PATCH v3 1/6] generic/749: Remove redundant sourcing of common/rc Nirjhar Roy (IBM)
2025-04-08 5:37 ` [PATCH v3 2/6] generic/367: Remove redundant sourcing if common/config Nirjhar Roy (IBM)
2025-04-08 9:06 ` Ritesh Harjani [this message]
2025-04-09 5:04 ` Zorro Lang
2025-04-08 5:37 ` [PATCH v3 3/6] check: Remove redundant _test_mount in check Nirjhar Roy (IBM)
2025-04-08 5:37 ` [PATCH v3 4/6] check,common{rc,preamble}: Decouple init_rc() call from sourcing common/rc Nirjhar Roy (IBM)
2025-04-08 5:37 ` [PATCH v3 5/6] common/config: Introduce _exit wrapper around exit command Nirjhar Roy (IBM)
2025-04-08 9:13 ` Ritesh Harjani
2025-04-08 16:15 ` Nirjhar Roy (IBM)
2025-04-08 16:32 ` Darrick J. Wong
2025-04-08 16:35 ` Nirjhar Roy (IBM)
2025-04-08 11:35 ` Dave Chinner
2025-04-08 16:43 ` Nirjhar Roy (IBM)
2025-04-09 0:44 ` Dave Chinner
2025-04-09 7:07 ` Nirjhar Roy (IBM)
2025-04-08 5:37 ` [PATCH v3 6/6] common: exit --> _exit Nirjhar Roy (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfgrja36.fsf@gmail.com \
--to=ritesh.list@gmail.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nirjhar.roy.lists@gmail.com \
--cc=ojaswin@linux.ibm.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox