From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87BD83D1CB5 for ; Sat, 1 Aug 2026 22:01:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785621698; cv=none; b=iIhI9D3IlMplV0skPXBqyMLL0c0Nyl7p4SkL6p9lH+wGxd8/EWI5T6vT/bMNVlnpm95Y2TRwxWrcrOCg+SGmf76fiZYbyg0xGZ+IEVVIhX47Z3i6QpU+p9SZVnWYwKADoY2THktJADdmrOdDb4yVN7LpbDIBq024wULFEtRHTmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785621698; c=relaxed/simple; bh=2bZmsqZVVuc9CfGIc+LM2Z9Btw3Dvkpcm1xyNQyplYM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RRprCU2UCKvbkL88bDkNoYGkzWTq3vTYzPwNbyr6rQbibqswdrpvN+7MdMIPg6GrgaoxcExdaOOv0irYNxAKaM8hkpsY9J1s9goC9rhJtSZFFvivsY6PZ7Ee5mPfZE98XJ+L1wdxxHzhPU9lM3kQXDiQeD9yZ6b8CT2V+D9Hf58= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z30IZIRH; arc=none smtp.client-ip=209.85.128.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z30IZIRH" Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-81ed2a00f12so31640047b3.2 for ; Sat, 01 Aug 2026 15:01:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785621695; x=1786226495; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qElo3yzh2qeHSY0scU/mBgdij9EIQBJHv2xpttY7cac=; b=Z30IZIRHurAGIj7N3745zgHKTG2pjmnNThmE9dNSZgam264BfRNFCm7OYh87fRHyIx w7z65QEIc5oZHERQx3nPRecefmfeZv6X+LT51z7X5iN1CXuiK8Yu0DmBkjPj42xHVwek 16Dfn4TKb1zsRMtDhFtBI203IfG8XUIy7F3M4kfTsXj8SenMb5E4zduiu8q7B1QgJRj0 KKvVklr1phauf9ope16nR8CqD6Ad27r6g5ufuKI7O1N075IewPYRbLVSQ3Tn3yv7lSd1 Bf87nG9xO4cCBJLUm8Qeya8fHtVPuwz97Qw9PD0figQ5iHfxai/ZUuEDJ5CD5Hthtv3d HXNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785621695; x=1786226495; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qElo3yzh2qeHSY0scU/mBgdij9EIQBJHv2xpttY7cac=; b=hwUfO/HOV/5wAJZS9on4Q6cYyD/lrl5AHj1xc0JNyaJNkcw0bVS0qsX6l7K9SUSPmk mUHfT39xv/UaX7Q59fnL99ESxhAaAAWrKi3zi/6krSH9L/0WJPZVFVfqOJBru5V14ObF voDx2EFu+Qd+iDf+Fx9gnjUw1KGdPNQznN/Zchvt92UrhEFR1PiV8NDmIsKdDbX5mwHT vmG6lP8EJfFfoqy4ChRonPmVDGYfPDAd+Ph2E4Oa2r4Ps2hnHyxNnpRNQCInW3miExal d53Tnxqshkp27wac3FgvmAieV2S5n8xCim97SyKRncVyYmQn241KNGuiAesZoKQAS0/u i8+w== X-Forwarded-Encrypted: i=1; AHgh+RokjcyriiLeXppr/I1gX6bvCdmnoIy0NmjPAwtb3UwIAxBlOLIWXAgEHPxF/QEe0hK0ihU9Y9MA4GVS@vger.kernel.org X-Gm-Message-State: AOJu0YytX4HVB7uIueP5xIYg8sFczRhjqINZW8Jzs/DlfOSFzS/1zOF6 +8Hgwm/blLk2wLGs3vB8o1hWhMiwODM3ATGAwA9IbaKd+zGDRrtf88my X-Gm-Gg: AR+sD10ockAAStEq+X1M/ctvG8e+LxS+kYI2kc+H4i2IuvG/Yv/13V9loCEf1XJdleA pEXZ7wPsN/v0KxlWmrca5LKwzTFSrIjEN9nui6uXuLYZ4Y0AVzGspWXnMbxN3PpU/DKIj7az3bf 18+QyvbIcAjRIlCqAAogMv/gcWTwDinCvWey40xWJO2RUbI251Rixevmn5hQLbSL9VeiaQxEa+T sp2INW8pCI7YqNiiVCQazugQMkis0T0BjFQ63e4/s3+g+PYvC3PAnxkHpsiQoK390sKOAVpPOxL 8qP+zJYnisU4LrjgH/rN+3HkHlUWUDf3A+FE4MYzGUdwoJ+QhUx6TITeZPi6eRuJ6d6CtW6Jvb5 plaxX3j6xIlgYjsi6E/ocPrfcdRrBzzPXxfGO8IBzm4ZTZp2J1Ie9v3aOFV6DiPK1kPKCUzXFwY CEXnP4Iq3xfmKzlQSAaPqFO78P/WlLZUdqakxk6c7i0ip7DleDxsau453SbI7yHgijMuqNqNBhQ myltuI= X-Received: by 2002:a05:690c:9981:b0:81e:a471:e8b0 with SMTP id 00721157ae682-81fd4b3e2d0mr70199667b3.21.1785621695043; Sat, 01 Aug 2026 15:01:35 -0700 (PDT) Received: from syssplab.cs.fiu.edu (nat1.cs.fiu.edu. [131.94.134.89]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81fcd0d6fbbsm29903767b3.25.2026.08.01.15.01.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 15:01:33 -0700 (PDT) From: Chao Shi To: Jan Kara , Christian Brauner , Alexander Viro , Matthew Wilcox , linux-fsdevel@vger.kernel.org Cc: Theodore Ts'o , Andreas Dilger , Baokun Li , Ojaswin Mujoo , Ritesh Harjani , Zhang Yi , Bob Copeland , Namjae Jeon , Sungjong Seo , Yuezhang Mo , OGAWA Hirofumi , Mark Fasheh , Joel Becker , Joseph Qi , Andreas Gruenbacher , linux-ext4@vger.kernel.org, ocfs2-devel@lists.linux.dev, gfs2@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Shi Subject: [PATCH 17/19] jbd2: assert on a failed write, not on a buffer that is not up to date Date: Sat, 1 Aug 2026 18:01:01 -0400 Message-ID: <8aa2ee674d147d3630f73f7b53fef7781f2aeccc.1785621505.git.coshi036@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit jbd2_freeze_jh_data() asserts that the buffer it is about to copy out is up to date. Once this series stops clearing BH_Uptodate on write error, that assertion stops firing for the case it was written for, because a buffer whose write failed stays up to date - which is the point: the in-memory copy being frozen is still the data the filesystem wants written. Assert on the condition that still means something went wrong. The message loses its "Possible", because BH_Write_EIO is not a guess. Suggested-by: Jan Kara Signed-off-by: Chao Shi --- fs/jbd2/transaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c index 5cc7d097b2ac..fdabe34a7e22 100644 --- a/fs/jbd2/transaction.c +++ b/fs/jbd2/transaction.c @@ -920,7 +920,7 @@ static void jbd2_freeze_jh_data(struct journal_head *jh) char *source; struct buffer_head *bh = jh2bh(jh); - J_EXPECT_JH(jh, buffer_uptodate(bh), "Possible IO failure.\n"); + J_EXPECT_JH(jh, !buffer_write_io_error(bh), "IO failure.\n"); source = kmap_local_folio(bh->b_folio, bh_offset(bh)); /* Fire data frozen trigger just before we copy the data */ jbd2_buffer_frozen_trigger(jh, source, jh->b_triggers); -- 2.43.0