From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23627C433DB for ; Thu, 25 Feb 2021 01:40:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CFC9764F03 for ; Thu, 25 Feb 2021 01:40:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234613AbhBYBkT (ORCPT ); Wed, 24 Feb 2021 20:40:19 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:13375 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234799AbhBYBkR (ORCPT ); Wed, 24 Feb 2021 20:40:17 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4DmFm70D9zz7m28; Thu, 25 Feb 2021 09:37:59 +0800 (CST) Received: from [127.0.0.1] (10.174.176.117) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.498.0; Thu, 25 Feb 2021 09:39:27 +0800 Subject: Re: [PATCH] debugfs: fix memory leak problem in read_list() To: Ext4 Developers List , "Theodore Y. Ts'o" CC: harshad shirwadkar , linfeilong , lihaotian , "lijinlin (A)" References: From: Zhiqiang Liu Message-ID: <8f18dd0d-aad2-1b34-d7a9-18b473f9c8b3@huawei.com> Date: Thu, 25 Feb 2021 09:39:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.176.117] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org friendly ping ... On 2021/2/20 16:41, Zhiqiang Liu wrote: > > In read_list func, if strtoull() fails in while loop, > we will return the error code directly. Then, memory of > variable lst will be leaked without setting to *list. > > Signed-off-by: Zhiqiang Liu > Signed-off-by: linfeilong > --- > debugfs/util.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/debugfs/util.c b/debugfs/util.c > index be6b550e..9e880548 100644 > --- a/debugfs/util.c > +++ b/debugfs/util.c > @@ -530,12 +530,16 @@ errcode_t read_list(char *str, blk64_t **list, size_t *len) > > errno = 0; > y = x = strtoull(tok, &e, 0); > - if (errno) > - return errno; > + if (errno) { > + retval = errno; > + break; > + } > if (*e == '-') { > y = strtoull(e + 1, NULL, 0); > - if (errno) > - return errno; > + if (errno) { > + retval = errno; > + break; > + } > } else if (*e != 0) { > retval = EINVAL; > break; >