From: Bixuan Cui <cuibixuan@linux.alibaba.com>
To: Jason Yan <yanaijie@huawei.com>,
rostedt@goodmis.org, mhiramat@kernel.org, bvanassche@acm.org,
axboe@kernel.dk, tytso@mit.edu, linux-kernel@vger.kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH -next] jbd2: use the correct print format
Date: Tue, 11 Oct 2022 19:23:30 +0800 [thread overview]
Message-ID: <9ac447b9-0cb5-2b03-12b5-9c3f1cc7e5fe@linux.alibaba.com> (raw)
In-Reply-To: <c30377f7-f9b8-5774-b509-a4285210b40f@huawei.com>
在 2022/10/10 22:35, Jason Yan 写道:
> While you are at it, can you make all the tid tracing consistent. Some
> tracing points using unsigned long such as:
>
> TRACE_EVENT(jbd2_handle_extend,
> TP_PROTO(dev_t dev, unsigned long tid, unsigned int type,
> unsigned int line_no, int buffer_credits,
> int requested_blocks),
>
> TP_ARGS(dev, tid, type, line_no, buffer_credits, requested_blocks),
>
>
> and the caller passing transaction->t_tid which is tid_t(unsigned int).
>
> trace_jbd2_handle_extend(journal->j_fs_dev->bd_dev,
> transaction->t_tid,
> handle->h_type, handle->h_line_no,
> handle->h_total_credits,
> nblocks);
Ok, I'll send another patch to fix this problem.
Thanks
Bixuan Cui
prev parent reply other threads:[~2022-10-11 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 8:09 [PATCH -next] jbd2: use the correct print format Bixuan Cui
2022-10-10 14:35 ` Jason Yan
2022-10-11 11:23 ` Bixuan Cui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ac447b9-0cb5-2b03-12b5-9c3f1cc7e5fe@linux.alibaba.com \
--to=cuibixuan@linux.alibaba.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tytso@mit.edu \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox