From: Steve French <smfrench@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: Andreas Dilger <adilger@dilger.ca>,
viro@zeniv.linux.org.uk, jlayton@redhat.com, mcao@us.ibm.com,
aneesh.kumar@linux.vnet.ibm.com, linux-cifs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
samba-technical@lists.samba.org, sjayaraman@suse.de,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] Ext4: Make file creation time, i_version and i_generation available by xattrs
Date: Mon, 28 Jun 2010 14:41:02 -0500 [thread overview]
Message-ID: <AANLkTikhZn15GmOTe-fsM2IgxHFxtZIRBOb_4kPWSR4E@mail.gmail.com> (raw)
In-Reply-To: <8831.1277753903@redhat.com>
On Mon, Jun 28, 2010 at 2:38 PM, David Howells <dhowells@redhat.com> wrote:
> Andreas Dilger <adilger@dilger.ca> wrote:
>
>> - I'd prefer calling these "file.generation" and "file.version".
>> I don't think there is value in the "i_" prefix adds anything,
>> and it seems more like an internal detail to me
>
> That's reasonable.
>
>> - why not expose the ".version" field for regular files? It seems
>> that all of them are applicable for all file types.
>
> Because Ext4 doesn't support it for anything other than directories.
>
>> - it would be good to not introduce a new xattr namespace, since
>> tools like tar (even the RHEL-patched one) will not backup and
>> restore these namespaces. Using "trusted." would allow them to
>> be backed up and restored using existing xattr-patched GNU tar
>> by root, but wouldn't allow them to be modified by regular users.
>> I think this is important for proper backup/restore of a filesystem,
>> but can have correctness implications and shouldn't be accessible
>> to regular users.
>
> Does backing them up make sense, though? They are filesystem structural
> attributes. Can you restore the inode number, for example? If not, then you
> can't restore i_generation either. Restoring i_version might make sense, but
> what if it winds i_version backwards whilst maintaining i_ino and i_generation,
> that means there'll be a time in the future where the three values are once
> again what might have been already published - and may already be in someone's
> persistent cache.
I think backing them up makes sense, even if they can't easily
be restored (ie just for reporting).
Are there security differences between the "trusted" namespace that
would make it harder for an app to read them (the man page did not list
the security differences between trusted and user xattrs).
--
Thanks,
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-06-28 19:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 16:26 [PATCH] Ext4: Make file creation time, i_version and i_generation available by xattrs David Howells
[not found] ` <20100628162626.6026.26679.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2010-06-28 16:33 ` Steve French
2010-06-28 16:48 ` Jeremy Allison
2010-06-28 17:04 ` Steve French
[not found] ` <AANLkTilkfPkvyuQvN9zKrrY3DhJZ5iUfa5RXfErFwTiA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-28 17:14 ` Jeremy Allison
2010-06-28 19:21 ` Christoph Hellwig
2010-06-29 22:44 ` David Howells
[not found] ` <26197.1277851477-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-29 22:59 ` Jeremy Allison
2010-06-29 23:31 ` David Howells
2010-06-28 19:08 ` Andreas Dilger
[not found] ` <19AAF9AA-2445-4C73-808B-4AD9C5C7E769-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org>
2010-06-28 19:38 ` David Howells
2010-06-28 19:41 ` Steve French [this message]
[not found] ` <AANLkTikhZn15GmOTe-fsM2IgxHFxtZIRBOb_4kPWSR4E-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-29 18:13 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikhZn15GmOTe-fsM2IgxHFxtZIRBOb_4kPWSR4E@mail.gmail.com \
--to=smfrench@gmail.com \
--cc=adilger@dilger.ca \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dhowells@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcao@us.ibm.com \
--cc=samba-technical@lists.samba.org \
--cc=sjayaraman@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).