Re: [PATCH] EXT4: move aio completion after unwritten extent conversion

[Jiaying Zhang <jiayingz@google.com>]

On Mon, Jun 28, 2010 at 7:49 AM, Christoph Hellwig <hch@infradead.org> wrote:
>
> >       if (io_end->flag != EXT4_IO_UNWRITTEN){
> >               ext4_free_io_end(io_end);
> >               iocb->private = NULL;
> > -             goto out;
> > +out:
> > +             if (is_async)
> > +                     aio_complete(iocb, ret, 0);
> > +             return;
>
> I'd suggest keeping the out label at the end of the function.  Without
> that the code gets unreadable very quickly.
>
I am fine with either. Having the 'out' exit label here saves us a jump in the
common code path while keeping it at the end of the function comply better
with the kernel code style. I will let Ted decide which one to take.

> >       io_end->size = size;
> > -     io_end->flag = EXT4_IO_UNWRITTEN;
>
> Why is this initialization removed?
>
This change is not related to the bug fix. I just realized that this
initialization seems to be unnecessary because we should already
return in the case that (io_end->flag != EXT4_IO_UNWRITTEN)
at the beginning of the function.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html