From: Akinobu Mita <akinobu.mita@gmail.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-kernel@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>,
linux-ext4@vger.kernel.org,
Yongqiang Yang <xiaoqiangnk@gmail.com>
Subject: Re: [PATCH v2 1/2] ext4: arrange ext4_*_bit() macros
Date: Thu, 2 Jun 2011 19:04:40 +0900 [thread overview]
Message-ID: <BANLkTi=mdiK7us_b-YKhiu60csQJTcihsw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTikSKyKuseG+iehh=-wfDCu46sinZw@mail.gmail.com>
2011/6/2 Amir Goldstein <amir73il@gmail.com>:
> FYI, one of the snapshot patches (snapshot_exclude_bitmap.patch)
> uses ext4_set_bit_atomic() to set bits in the exclude bitmap when
> moving blocks to snapshot file.
> Since moving blocks is not done in allocation context, there is no
> buddy/group lock held while manipulating the exclude bitmap.
> So I would appreciate if this specific macro will not be removed.
>
> Thanks, Yongqiang , for pointing that out.
OK, I'll keep ext4_*_bit_atomic() in the next version.
prev parent reply other threads:[~2011-06-02 10:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 14:36 [PATCH v2 1/2] ext4: arrange ext4_*_bit() macros Akinobu Mita
2011-06-01 14:36 ` [PATCH v2 2/2] ext4: use proper " Akinobu Mita
2011-06-01 20:49 ` [PATCH v2 1/2] ext4: arrange " Andreas Dilger
2011-06-02 1:25 ` Akinobu Mita
2011-06-02 8:50 ` Amir Goldstein
2011-06-02 10:04 ` Akinobu Mita [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=mdiK7us_b-YKhiu60csQJTcihsw@mail.gmail.com' \
--to=akinobu.mita@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=amir73il@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).