* Re: [PATCH 1/2] Jbd2: fix a bug of leaking jh->b_jcount
[not found] <-1724257416234743088@unknownmsgid>
@ 2011-05-25 10:49 ` Yongqiang Yang
2011-05-25 12:02 ` Theodore Tso
2011-05-25 22:14 ` Ted Ts'o
0 siblings, 2 replies; 9+ messages in thread
From: Yongqiang Yang @ 2011-05-25 10:49 UTC (permalink / raw)
To: y; +Cc: linux-ext4, Ding Dinghua
Signed-off-by: line was missed.
On Wed, May 25, 2011 at 6:19 PM, <y@mx.nrchpc.ac.cn> wrote:
> From: Ding Dinghua <dingdinghua@nrchpc.ac.cn>
>
> drop jh->b_jcount in error path
> ---
> fs/jbd2/transaction.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> index 05fa77a..d66672a 100644
> --- a/fs/jbd2/transaction.c
> +++ b/fs/jbd2/transaction.c
> @@ -921,8 +921,8 @@ int jbd2_journal_get_create_access(handle_t *handle, struct buffer_head *bh)
> */
> JBUFFER_TRACE(jh, "cancelling revoke");
> jbd2_journal_cancel_revoke(handle, jh);
> - jbd2_journal_put_journal_head(jh);
> out:
> + jbd2_journal_put_journal_head(jh);
> return err;
> }
>
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Best Wishes
Yongqiang Yang
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/2] Jbd2: fix a bug of leaking jh->b_jcount
2011-05-25 10:49 ` [PATCH 1/2] Jbd2: fix a bug of leaking jh->b_jcount Yongqiang Yang
@ 2011-05-25 12:02 ` Theodore Tso
2011-05-25 22:14 ` Ted Ts'o
1 sibling, 0 replies; 9+ messages in thread
From: Theodore Tso @ 2011-05-25 12:02 UTC (permalink / raw)
To: Yongqiang Yang; +Cc: y, linux-ext4, Ding Dinghua
On May 25, 2011, at 6:49 AM, Yongqiang Yang wrote:
> Signed-off-by: line was missed.
Also, one request --- if the leak is one that happens on the error path, please say so in the commit summary. That changes the priority of the patch compared to something which is much higher priority if it is always leaking on the common case code path.
Thanks!!
-- Ted
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] Jbd2: fix a bug of leaking jh->b_jcount
2011-05-25 10:49 ` [PATCH 1/2] Jbd2: fix a bug of leaking jh->b_jcount Yongqiang Yang
2011-05-25 12:02 ` Theodore Tso
@ 2011-05-25 22:14 ` Ted Ts'o
2011-05-26 11:25 ` Ding Dinghua
1 sibling, 1 reply; 9+ messages in thread
From: Ted Ts'o @ 2011-05-25 22:14 UTC (permalink / raw)
To: Yongqiang Yang; +Cc: y, linux-ext4, Ding Dinghua
On Wed, May 25, 2011 at 06:49:57PM +0800, Yongqiang Yang wrote:
> Signed-off-by: line was missed.
Ding,
Please resend the patch with the Signed-off-by, or tell me explicitly
that it's OK to add:
Signed-off-by: Ding Dinghua <dingdinghua@nrchpc.ac.cn>
The signed-off-by has legal meaning (see below) so it's not something
I want to add on my own initiative without getting an explicit ack
from the original author.
Regards,
- Ted
(From /usr/src/linux/Documentation/SubmittingPatches)
12) Sign your work
To improve tracking of who did what, especially with patches that can
percolate to their final resting place in the kernel through several
layers of maintainers, we've introduced a "sign-off" procedure on
patches that are being emailed around.
The sign-off is a simple line at the end of the explanation for the
patch, which certifies that you wrote it or otherwise have the right to
pass it on as a open-source patch. The rules are pretty simple: if you
can certify the below:
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
then you just add a line saying
Signed-off-by: Random J Developer <random@developer.example.org>
using your real name (sorry, no pseudonyms or anonymous contributions.)
Some people also put extra tags at the end. They'll just be ignored for
now, but you can do this to mark internal company procedures or just
point out some special detail about the sign-off.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/2] Jbd2: fix a bug of leaking jh->b_jcount
2011-05-25 22:14 ` Ted Ts'o
@ 2011-05-26 11:25 ` Ding Dinghua
0 siblings, 0 replies; 9+ messages in thread
From: Ding Dinghua @ 2011-05-26 11:25 UTC (permalink / raw)
To: Ted Ts'o; +Cc: linux-ext4
Hi Ted,
thanks for your suggestion, i have resent the patches, please have a look.
Ted Ts'o wrote:
> On Wed, May 25, 2011 at 06:49:57PM +0800, Yongqiang Yang wrote:
>
>> Signed-off-by: line was missed.
>>
>
> Ding,
>
> Please resend the patch with the Signed-off-by, or tell me explicitly
> that it's OK to add:
>
> Signed-off-by: Ding Dinghua <dingdinghua@nrchpc.ac.cn>
>
> The signed-off-by has legal meaning (see below) so it's not something
> I want to add on my own initiative without getting an explicit ack
> from the original author.
>
> Regards,
>
> - Ted
>
> (From /usr/src/linux/Documentation/SubmittingPatches)
>
> 12) Sign your work
>
> To improve tracking of who did what, especially with patches that can
> percolate to their final resting place in the kernel through several
> layers of maintainers, we've introduced a "sign-off" procedure on
> patches that are being emailed around.
>
> The sign-off is a simple line at the end of the explanation for the
> patch, which certifies that you wrote it or otherwise have the right to
> pass it on as a open-source patch. The rules are pretty simple: if you
> can certify the below:
>
> Developer's Certificate of Origin 1.1
>
> By making a contribution to this project, I certify that:
>
> (a) The contribution was created in whole or in part by me and I
> have the right to submit it under the open source license
> indicated in the file; or
>
> (b) The contribution is based upon previous work that, to the best
> of my knowledge, is covered under an appropriate open source
> license and I have the right under that license to submit that
> work with modifications, whether created in whole or in part
> by me, under the same open source license (unless I am
> permitted to submit under a different license), as indicated
> in the file; or
>
> (c) The contribution was provided directly to me by some other
> person who certified (a), (b) or (c) and I have not modified
> it.
>
> (d) I understand and agree that this project and the contribution
> are public and that a record of the contribution (including all
> personal information I submit with it, including my sign-off) is
> maintained indefinitely and may be redistributed consistent with
> this project or the open source license(s) involved.
>
> then you just add a line saying
>
> Signed-off-by: Random J Developer <random@developer.example.org>
>
> using your real name (sorry, no pseudonyms or anonymous contributions.)
>
> Some people also put extra tags at the end. They'll just be ignored for
> now, but you can do this to mark internal company procedures or just
> point out some special detail about the sign-off.
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] jbd2: fix a bug of leaking jh->b_jcount
@ 2011-05-26 2:28 Ding Dinghua
2011-05-26 15:16 ` Ted Ts'o
0 siblings, 1 reply; 9+ messages in thread
From: Ding Dinghua @ 2011-05-26 2:28 UTC (permalink / raw)
To: linux-ext4; +Cc: dingdinghua
jbd2_journal_get_create_access should drop jh->b_jcount in error
handling path
Signed-off-by: Ding Dinghua <dingdinghua@nrchpc.ac.cn>
---
fs/jbd2/transaction.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
index 05fa77a..d66672a 100644
--- a/fs/jbd2/transaction.c
+++ b/fs/jbd2/transaction.c
@@ -921,8 +921,8 @@ int jbd2_journal_get_create_access(handle_t *handle, struct buffer_head *bh)
*/
JBUFFER_TRACE(jh, "cancelling revoke");
jbd2_journal_cancel_revoke(handle, jh);
- jbd2_journal_put_journal_head(jh);
out:
+ jbd2_journal_put_journal_head(jh);
return err;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 1/2] jbd2: fix a bug of leaking jh->b_jcount
@ 2011-05-26 2:02 dingdinghua
2011-05-26 2:10 ` 丁定华
0 siblings, 1 reply; 9+ messages in thread
From: dingdinghua @ 2011-05-26 2:02 UTC (permalink / raw)
To: linux-ext4; +Cc: dingdinghua
From: Ding Dinghua <dingdinghua@nrchpc.ac.cn>
jbd2_journal_get_create_access should drop jh->b_jount in error
handling path
---
fs/jbd2/transaction.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
index 05fa77a..d66672a 100644
--- a/fs/jbd2/transaction.c
+++ b/fs/jbd2/transaction.c
@@ -921,8 +921,8 @@ int jbd2_journal_get_create_access(handle_t *handle, struct buffer_head *bh)
*/
JBUFFER_TRACE(jh, "cancelling revoke");
jbd2_journal_cancel_revoke(handle, jh);
- jbd2_journal_put_journal_head(jh);
out:
+ jbd2_journal_put_journal_head(jh);
return err;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] jbd2: fix a bug of leaking jh->b_jcount
2011-05-26 2:02 dingdinghua
@ 2011-05-26 2:10 ` 丁定华
0 siblings, 0 replies; 9+ messages in thread
From: 丁定华 @ 2011-05-26 2:10 UTC (permalink / raw)
To: linux-ext4
oops, I still forget to add signoff line, please ignore this patch,
i will resend it.
2011/5/26 <dingdinghua@nrchpc.ac.cn>:
> From: Ding Dinghua <dingdinghua@nrchpc.ac.cn>
>
> jbd2_journal_get_create_access should drop jh->b_jount in error
> handling path
> ---
> fs/jbd2/transaction.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> index 05fa77a..d66672a 100644
> --- a/fs/jbd2/transaction.c
> +++ b/fs/jbd2/transaction.c
> @@ -921,8 +921,8 @@ int jbd2_journal_get_create_access(handle_t *handle, struct buffer_head *bh)
> */
> JBUFFER_TRACE(jh, "cancelling revoke");
> jbd2_journal_cancel_revoke(handle, jh);
> - jbd2_journal_put_journal_head(jh);
> out:
> + jbd2_journal_put_journal_head(jh);
> return err;
> }
>
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Ding Dinghua
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] Jbd2: fix a bug of leaking jh->b_jcount
@ 2011-05-25 10:19 y
0 siblings, 0 replies; 9+ messages in thread
From: y @ 2011-05-25 10:19 UTC (permalink / raw)
To: linux-ext4; +Cc: Ding Dinghua
From: Ding Dinghua <dingdinghua@nrchpc.ac.cn>
drop jh->b_jcount in error path
---
fs/jbd2/transaction.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
index 05fa77a..d66672a 100644
--- a/fs/jbd2/transaction.c
+++ b/fs/jbd2/transaction.c
@@ -921,8 +921,8 @@ int jbd2_journal_get_create_access(handle_t *handle, struct buffer_head *bh)
*/
JBUFFER_TRACE(jh, "cancelling revoke");
jbd2_journal_cancel_revoke(handle, jh);
- jbd2_journal_put_journal_head(jh);
out:
+ jbd2_journal_put_journal_head(jh);
return err;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-05-26 15:16 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <-1724257416234743088@unknownmsgid>
2011-05-25 10:49 ` [PATCH 1/2] Jbd2: fix a bug of leaking jh->b_jcount Yongqiang Yang
2011-05-25 12:02 ` Theodore Tso
2011-05-25 22:14 ` Ted Ts'o
2011-05-26 11:25 ` Ding Dinghua
2011-05-26 2:28 [PATCH 1/2] jbd2: " Ding Dinghua
2011-05-26 15:16 ` Ted Ts'o
-- strict thread matches above, loose matches on Subject: below --
2011-05-26 2:02 dingdinghua
2011-05-26 2:10 ` 丁定华
2011-05-25 10:19 [PATCH 1/2] Jbd2: " y
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).