From: Yongqiang Yang <xiaoqiangnk@gmail.com>
To: Ding Dinghua <dingdinghua@nrchpc.ac.cn>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] Jbd: fix a bug of leaking jh->b_jcount
Date: Wed, 25 May 2011 19:47:14 +0800 [thread overview]
Message-ID: <BANLkTim992S6+iGEN12NfcuOz-UOSe2prQ@mail.gmail.com> (raw)
In-Reply-To: <BANLkTik=B08XzLViSD10Z_bac6R5DqswmA@mail.gmail.com>
On Wed, May 25, 2011 at 7:37 PM, Yongqiang Yang <xiaoqiangnk@gmail.com> wrote:
> Hi,
>
> m/N means that there are N patches and this patch is the mst one. e.g.
> 2/30 means the patch series contain 30 patches and this is the 2nd
> one.
>
> When a patch is resent, you'd better send it with [PACH vm], where m
> is the version number.
Sorry, two patches are different, please ignore comments above.
>
> Again, you missed Signed-off-by: line.
>
> On Wed, May 25, 2011 at 6:20 PM, Ding Dinghua <dingdinghua@nrchpc.ac.cn> wrote:
>> drop jh->b_jcount in error path
>> ---
>> fs/jbd/transaction.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
>> index 60d2319..3f7bf84 100644
>> --- a/fs/jbd/transaction.c
>> +++ b/fs/jbd/transaction.c
>> @@ -843,8 +843,8 @@ int journal_get_create_access(handle_t *handle, struct buffer_head *bh)
>> */
>> JBUFFER_TRACE(jh, "cancelling revoke");
>> journal_cancel_revoke(handle, jh);
>> - journal_put_journal_head(jh);
>> out:
>> + journal_put_journal_head(jh);
>> return err;
>> }
>>
>> --
>> 1.7.4.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
>
>
> --
> Best Wishes
> Yongqiang Yang
>
--
Best Wishes
Yongqiang Yang
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-05-25 11:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 10:20 [PATCH 2/2] Jbd: fix a bug of leaking jh->b_jcount Ding Dinghua
2011-05-25 11:37 ` Yongqiang Yang
2011-05-25 11:47 ` Yongqiang Yang [this message]
2011-05-25 13:48 ` Ted Ts'o
-- strict thread matches above, loose matches on Subject: below --
2011-05-26 2:29 [PATCH 2/2] jbd: " Ding Dinghua
2011-05-30 10:32 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTim992S6+iGEN12NfcuOz-UOSe2prQ@mail.gmail.com \
--to=xiaoqiangnk@gmail.com \
--cc=dingdinghua@nrchpc.ac.cn \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).