* [PATCH 2/2] Jbd: fix a bug of leaking jh->b_jcount
@ 2011-05-25 10:20 Ding Dinghua
2011-05-25 11:37 ` Yongqiang Yang
0 siblings, 1 reply; 6+ messages in thread
From: Ding Dinghua @ 2011-05-25 10:20 UTC (permalink / raw)
To: linux-ext4; +Cc: Ding Dinghua
drop jh->b_jcount in error path
---
fs/jbd/transaction.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
index 60d2319..3f7bf84 100644
--- a/fs/jbd/transaction.c
+++ b/fs/jbd/transaction.c
@@ -843,8 +843,8 @@ int journal_get_create_access(handle_t *handle, struct buffer_head *bh)
*/
JBUFFER_TRACE(jh, "cancelling revoke");
journal_cancel_revoke(handle, jh);
- journal_put_journal_head(jh);
out:
+ journal_put_journal_head(jh);
return err;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] Jbd: fix a bug of leaking jh->b_jcount
2011-05-25 10:20 [PATCH 2/2] Jbd: fix a bug of leaking jh->b_jcount Ding Dinghua
@ 2011-05-25 11:37 ` Yongqiang Yang
2011-05-25 11:47 ` Yongqiang Yang
0 siblings, 1 reply; 6+ messages in thread
From: Yongqiang Yang @ 2011-05-25 11:37 UTC (permalink / raw)
To: Ding Dinghua; +Cc: linux-ext4
Hi,
m/N means that there are N patches and this patch is the mst one. e.g.
2/30 means the patch series contain 30 patches and this is the 2nd
one.
When a patch is resent, you'd better send it with [PACH vm], where m
is the version number.
Again, you missed Signed-off-by: line.
On Wed, May 25, 2011 at 6:20 PM, Ding Dinghua <dingdinghua@nrchpc.ac.cn> wrote:
> drop jh->b_jcount in error path
> ---
> fs/jbd/transaction.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
> index 60d2319..3f7bf84 100644
> --- a/fs/jbd/transaction.c
> +++ b/fs/jbd/transaction.c
> @@ -843,8 +843,8 @@ int journal_get_create_access(handle_t *handle, struct buffer_head *bh)
> */
> JBUFFER_TRACE(jh, "cancelling revoke");
> journal_cancel_revoke(handle, jh);
> - journal_put_journal_head(jh);
> out:
> + journal_put_journal_head(jh);
> return err;
> }
>
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Best Wishes
Yongqiang Yang
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] Jbd: fix a bug of leaking jh->b_jcount
2011-05-25 11:37 ` Yongqiang Yang
@ 2011-05-25 11:47 ` Yongqiang Yang
2011-05-25 13:48 ` Ted Ts'o
0 siblings, 1 reply; 6+ messages in thread
From: Yongqiang Yang @ 2011-05-25 11:47 UTC (permalink / raw)
To: Ding Dinghua; +Cc: linux-ext4
On Wed, May 25, 2011 at 7:37 PM, Yongqiang Yang <xiaoqiangnk@gmail.com> wrote:
> Hi,
>
> m/N means that there are N patches and this patch is the mst one. e.g.
> 2/30 means the patch series contain 30 patches and this is the 2nd
> one.
>
> When a patch is resent, you'd better send it with [PACH vm], where m
> is the version number.
Sorry, two patches are different, please ignore comments above.
>
> Again, you missed Signed-off-by: line.
>
> On Wed, May 25, 2011 at 6:20 PM, Ding Dinghua <dingdinghua@nrchpc.ac.cn> wrote:
>> drop jh->b_jcount in error path
>> ---
>> fs/jbd/transaction.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
>> index 60d2319..3f7bf84 100644
>> --- a/fs/jbd/transaction.c
>> +++ b/fs/jbd/transaction.c
>> @@ -843,8 +843,8 @@ int journal_get_create_access(handle_t *handle, struct buffer_head *bh)
>> */
>> JBUFFER_TRACE(jh, "cancelling revoke");
>> journal_cancel_revoke(handle, jh);
>> - journal_put_journal_head(jh);
>> out:
>> + journal_put_journal_head(jh);
>> return err;
>> }
>>
>> --
>> 1.7.4.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
>
>
> --
> Best Wishes
> Yongqiang Yang
>
--
Best Wishes
Yongqiang Yang
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] Jbd: fix a bug of leaking jh->b_jcount
2011-05-25 11:47 ` Yongqiang Yang
@ 2011-05-25 13:48 ` Ted Ts'o
0 siblings, 0 replies; 6+ messages in thread
From: Ted Ts'o @ 2011-05-25 13:48 UTC (permalink / raw)
To: Yongqiang Yang; +Cc: Ding Dinghua, linux-ext4
On Wed, May 25, 2011 at 07:47:14PM +0800, Yongqiang Yang wrote:
> On Wed, May 25, 2011 at 7:37 PM, Yongqiang Yang <xiaoqiangnk@gmail.com> wrote:
> > Hi,
> >
> > m/N means that there are N patches and this patch is the mst one. e.g.
> > 2/30 means the patch series contain 30 patches and this is the 2nd
> > one.
> >
> > When a patch is resent, you'd better send it with [PACH vm], where m
> > is the version number.
> Sorry, two patches are different, please ignore comments above.
... and this is why it's a REALLY GOOD IDEA to make patch 2/2 have a
In-Reply-To: header that references the message id of patch 1/2. It
avoids this sort of confusion.
And again, git format-patch and git send-email will do all of this
automatically for you...
- Ted
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] jbd: fix a bug of leaking jh->b_jcount
@ 2011-05-26 2:29 Ding Dinghua
2011-05-30 10:32 ` Jan Kara
0 siblings, 1 reply; 6+ messages in thread
From: Ding Dinghua @ 2011-05-26 2:29 UTC (permalink / raw)
To: linux-ext4; +Cc: dingdinghua
journal_get_create_access should drop jh->b_jcount in error handling path
Signed-off-by: Ding Dinghua <dingdinghua@nrchpc.ac.cn>
---
fs/jbd/transaction.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
index f7ee81a..3b3b01f 100644
--- a/fs/jbd/transaction.c
+++ b/fs/jbd/transaction.c
@@ -844,8 +844,8 @@ int journal_get_create_access(handle_t *handle, struct buffer_head *bh)
*/
JBUFFER_TRACE(jh, "cancelling revoke");
journal_cancel_revoke(handle, jh);
- journal_put_journal_head(jh);
out:
+ journal_put_journal_head(jh);
return err;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] jbd: fix a bug of leaking jh->b_jcount
2011-05-26 2:29 [PATCH 2/2] jbd: " Ding Dinghua
@ 2011-05-30 10:32 ` Jan Kara
0 siblings, 0 replies; 6+ messages in thread
From: Jan Kara @ 2011-05-30 10:32 UTC (permalink / raw)
To: Ding Dinghua; +Cc: linux-ext4
On Thu 26-05-11 10:29:01, Ding Dinghua wrote:
> journal_get_create_access should drop jh->b_jcount in error handling path
>
> Signed-off-by: Ding Dinghua <dingdinghua@nrchpc.ac.cn>
Thanks. Merged into my tree.
Honza
> ---
> fs/jbd/transaction.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
> index f7ee81a..3b3b01f 100644
> --- a/fs/jbd/transaction.c
> +++ b/fs/jbd/transaction.c
> @@ -844,8 +844,8 @@ int journal_get_create_access(handle_t *handle, struct buffer_head *bh)
> */
> JBUFFER_TRACE(jh, "cancelling revoke");
> journal_cancel_revoke(handle, jh);
> - journal_put_journal_head(jh);
> out:
> + journal_put_journal_head(jh);
> return err;
> }
>
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-05-30 10:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-25 10:20 [PATCH 2/2] Jbd: fix a bug of leaking jh->b_jcount Ding Dinghua
2011-05-25 11:37 ` Yongqiang Yang
2011-05-25 11:47 ` Yongqiang Yang
2011-05-25 13:48 ` Ted Ts'o
-- strict thread matches above, loose matches on Subject: below --
2011-05-26 2:29 [PATCH 2/2] jbd: " Ding Dinghua
2011-05-30 10:32 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).