From: Manish Katiyar <mkatiyar@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: jack@suse.cz, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] jbd: Make jbd transactions come from its own cache.
Date: Mon, 13 Jun 2011 17:02:51 -0700 [thread overview]
Message-ID: <BANLkTimhnzadsUOYCJ2J--GfJL74svFPnw@mail.gmail.com> (raw)
In-Reply-To: <20110613164121.d2ca952e.akpm@linux-foundation.org>
On Mon, Jun 13, 2011 at 4:41 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Sat, 11 Jun 2011 02:36:01 -0700
> Manish Katiyar <mkatiyar@gmail.com> wrote:
>
>> Allocate a slab cache for jbd transaction allocations. It may help to test
>> various memory failure scenarios.
>
> This doesn't seem terribly useful to me. That's truly ancient code and
> the change rate is really low. If there were problem in there then
> we'd already know about them. And the allocation frequency for these
> objects is very low.
>
> If you had some deeper reason for making this change, please describe
> it. For example, were you chasing some bug?
Hi Andrew,
I was doing similar changes for jbd2, hence did it for jbd too. The
changes for jbd2 were done so that we can use the
fault injection framework to introduce/test ENOMEM situations from the
journal transaction allocation layer and test
how well the callers (ext4 code in particular) deal with such
situations and fix them if required.
--
Thanks -
Manish
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-06-14 0:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-11 9:36 [PATCH] jbd: Make jbd transactions come from its own cache Manish Katiyar
2011-06-13 23:41 ` Andrew Morton
2011-06-14 0:02 ` Manish Katiyar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimhnzadsUOYCJ2J--GfJL74svFPnw@mail.gmail.com \
--to=mkatiyar@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).