From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amir Goldstein Subject: Re: [PATCH v3] ext4:Let ext4_ext_fiemap_cb() handle blocks before request range correctly. Date: Sun, 22 May 2011 11:35:59 +0300 Message-ID: References: <1305545234-11751-1-git-send-email-xiaoqiangnk@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: base64 Cc: linux-ext4@vger.kernel.org, lczerner@redhat.com, tytso@mit.edu To: Yongqiang Yang Return-path: Received: from mail-ew0-f46.google.com ([209.85.215.46]:57336 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625Ab1EVIgB (ORCPT ); Sun, 22 May 2011 04:36:01 -0400 Received: by ewy4 with SMTP id 4so1537140ewy.19 for ; Sun, 22 May 2011 01:35:59 -0700 (PDT) In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: T24gTW9uLCBNYXkgMTYsIDIwMTEgYXQgNDoxNSBQTSwgWW9uZ3FpYW5nIFlhbmcgPHhpYW9xaWFu Z25rQGdtYWlsLmNvbT4gd3JvdGU6Cj4gT24gTW9uLCBNYXkgMTYsIDIwMTEgYXQgNzo1MyBQTSwg QW1pciBHb2xkc3RlaW4gPGFtaXI3M2lsQGdtYWlsLmNvbT4gd3JvdGU6Cj4+IE9uIE1vbiwgTWF5 IDE2LCAyMDExIGF0IDI6MjcgUE0sIFlvbmdxaWFuZyBZYW5nIDx4aWFvcWlhbmdua0BnbWFpbC5j b20+IHdyb3RlOgo+Pj4gVG8gZ2V0IGRlbGF5ZWQtZXh0ZW50IGluZm9ybWF0aW9uLCBleHQ0X2V4 dF9maWVtYXBfY2IoKSBsb29rcyB1cAo+Pj4gcGFnZWNhY2hlLCBpdCB0aHVzIGNvbGxlY3RzIGlu Zm9ybWF0aW9uIHN0YXJ0aW5nIGZyb20gYSBwYWdlJ3MKPj4+IGhlYWQgYmxvY2suCj4+Pgo+Pj4g SWYgYmxvY2tzaXplIDwgcGFnZXNpemUsIHRoZSBiZWdpbm5pbmcgYmxvY2tzIG9mIGEgcGFnZSBt YXkgbGllcwo+Pj4gYmVmb3JlIHRoZSByZXF1ZXN0IHJhbmdlLiBTbyBleHQ0X2V4dF9maWVtYXBf Y2IoKSBzaG91bGQgcHJvY2VlZAo+Pj4gaWdub3JpbmcgdGhlbSwgYmVjYXVzZSB0aGV5IGhhcyBi ZWVuIGhhbmRsZWQgYmVmb3JlLiBJZiBubyBtYXBwZWQKPj4+IGJ1ZmZlciBpbiB0aGUgcmFuZ2Ug aXMgZm91bmQgaW4gdGhlIDFzdCBwYWdlLCB3ZSBuZWVkIHRvIGxvb2sgdXAKPj4+IHRoZSAybmQg cGFnZSwgb3RoZXJ3aXNlIGRlbGF5ZWQtZXh0ZW50cyBhZnRlciBhIGhvbGUgd2lsbCBiZSBpZ25v cmVkLgo+Pgo+PiBEb2VzIHRoaXMgcGF0Y2ggZml4IHRoZSBlbmRsZXNzIGxvb3AgSSBlbmNvdW50 ZXJlZD8KPiBZZXMsIGl0IGZpeGVzIGFub3RoZXIgYnVnLgo+PiBJZiBzbywgeW91IG1heSB3YW50 IHRvIGFkZCB0byBjb21taXQgbWVzc2FnZToKPj4gLSBSZXBvcnRlZC1ieTogQW1pci4uCj4+IC0g dGhhdCB0aGUgcGF0Y2ggZml4ZXMgYSBoYW5nIGJ1Zwo+PiAtIGhvdyB3YXMgaXQgcmVwcm9kdWNl ZAo+PiAtIHdoaWNoIGNvbW1pdCBpbnRyb2R1Y2VkIHRoZSBidWcKPiBTb3JyeSwgSSBmb3Jnb3Qg dG8gYWRkIHRoZXNlLiCgIEkgcmV3cm90ZSB0aGUgeGZzdGVzdHMgMjI1IGFuZCBmb3VuZAo+IGFu b3RoZXIgYnVnIHdoaWNoIHRoZSBvbGQgMjI1IGNvdWxkIG5vdCBmaW5kLgo+IEkgdGhpbmsgSSBz aG91bGQgcmVzZW5kIHRoaXMgcGF0Y2guCgpIaSBZb25ncWlhbmcsCgpEaWQgeW91IHJlc2VuZCB0 aGlzIHBhdGNoPyBJIHNlZSB0aGF0IFRlZCBoYXNuJ3QgcGlja2VkIGl0IHVwIHlldC4KQXBwYXJl bnRseSwgaGUgaXMgZXhwZWN0aW5nIHRvIGdldCBhIG5ldyB2ZXJzaW9uIGZyb20geW91IHdpdGgg cHJvcGVyCmNvbW1pdCBsb2cgKEkgdGhpbmsgaGUgbWVudGlvbmVkIHRoYXQgb24gbGFzdCB3ZWVr J3MgY29uZmNhbGwpLgoKQW1pci4KCj4KPj4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBZb25ncWlh bmcgWWFuZyA8eGlhb3FpYW5nbmtAZ21haWwuY29tPgo+Pj4gLS0tCj4+PiCgZnMvZXh0NC9leHRl bnRzLmMgfCCgIDUxICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0t LS0tLS0tLQo+Pj4goDEgZmlsZXMgY2hhbmdlZCwgMzYgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRp b25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2ZzL2V4dDQvZXh0ZW50cy5jIGIvZnMvZXh0NC9l eHRlbnRzLmMKPj4+IGluZGV4IGUzNjNmMjEuLjQ3NGVhYWQgMTAwNjQ0Cj4+PiAtLS0gYS9mcy9l eHQ0L2V4dGVudHMuYwo+Pj4gKysrIGIvZnMvZXh0NC9leHRlbnRzLmMKPj4+IEBAIC0zNjgwLDYg KzM2ODAsNyBAQCBzdGF0aWMgaW50IGV4dDRfZXh0X2ZpZW1hcF9jYihzdHJ1Y3QgaW5vZGUgKmlu b2RlLCBzdHJ1Y3QgZXh0NF9leHRfcGF0aCAqcGF0aCwKPj4+IKAgoCCgIKAgoCCgIKAgoHBnb2Zm X3QgoCCgIKAgoCBsYXN0X29mZnNldDsKPj4+IKAgoCCgIKAgoCCgIKAgoHBnb2ZmX3QgoCCgIKAg oCBvZmZzZXQ7Cj4+PiCgIKAgoCCgIKAgoCCgIKBwZ29mZl90IKAgoCCgIKAgaW5kZXg7Cj4+PiAr IKAgoCCgIKAgoCCgIKAgcGdvZmZfdCCgIKAgoCCgIHN0YXJ0X2luZGV4ID0gMDsKPj4+IKAgoCCg IKAgoCCgIKAgoHN0cnVjdCBwYWdlIKAgoCAqKnBhZ2VzID0gTlVMTDsKPj4+IKAgoCCgIKAgoCCg IKAgoHN0cnVjdCBidWZmZXJfaGVhZCAqYmggPSBOVUxMOwo+Pj4goCCgIKAgoCCgIKAgoCCgc3Ry dWN0IGJ1ZmZlcl9oZWFkICpoZWFkID0gTlVMTDsKPj4+IEBAIC0zNzA2LDM5ICszNzA3LDU3IEBA IG91dDoKPj4+IKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKBrZnJlZShwYWdlcyk7Cj4+ PiCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgcmV0dXJuIEVYVF9DT05USU5VRTsKPj4+ IKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgfQo+Pj4gKyCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgaW5k ZXggPSAwOwo+Pj4KPj4+ICtuZXh0X3BhZ2U6Cj4+PiCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoC8q IFRyeSB0byBmaW5kIHRoZSAxc3QgbWFwcGVkIGJ1ZmZlci4gKi8KPj4+IC0goCCgIKAgoCCgIKAg oCCgIKAgoCCgIGVuZCA9ICgoX191NjQpcGFnZXNbMF0tPmluZGV4IDw8IFBBR0VfU0hJRlQpID4+ Cj4+PiArIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCBlbmQgPSAoKF9fdTY0KXBhZ2VzW2luZGV4XS0+ aW5kZXggPDwgUEFHRV9TSElGVCkgPj4KPj4+IKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCg IKAgoGJsa3NpemVfYml0czsKPj4+IC0goCCgIKAgoCCgIKAgoCCgIKAgoCCgIGlmICghcGFnZV9o YXNfYnVmZmVycyhwYWdlc1swXSkpCj4+PiArIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCBpZiAoIXBh Z2VfaGFzX2J1ZmZlcnMocGFnZXNbaW5kZXhdKSkKPj4+IKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCg IKAgoCCgIKBnb3RvIG91dDsKPj4+IC0goCCgIKAgoCCgIKAgoCCgIKAgoCCgIGhlYWQgPSBwYWdl X2J1ZmZlcnMocGFnZXNbMF0pOwo+Pj4gKyCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgaGVhZCA9IHBh Z2VfYnVmZmVycyhwYWdlc1tpbmRleF0pOwo+Pj4goCCgIKAgoCCgIKAgoCCgIKAgoCCgIKBpZiAo IWhlYWQpCj4+PiCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgZ290byBvdXQ7Cj4+PiAt Cj4+PiArCj4+PiArIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCBpbmRleCsrOwo+Pj4goCCgIKAgoCCg IKAgoCCgIKAgoCCgIKBiaCA9IGhlYWQ7Cj4+PiCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoGRvIHsK Pj4+IC0goCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgaWYgKGJ1ZmZlcl9tYXBwZWQoYmgp KSB7Cj4+PiArIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIGlmIChlbmQgPj0gbmV3ZXgt PmVjX2Jsb2NrICsKPj4+ICsgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCBu ZXdleC0+ZWNfbGVuKQo+Pj4gKyCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCg IC8qIFRoZSBidWZmZXIgaXMgb3V0IG9mCj4+PiArIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAg oCCgIKAgoCCgIKAgoCogdGhlIHJlcXVlc3QgcmFuZ2UuCj4+PiArIKAgoCCgIKAgoCCgIKAgoCCg IKAgoCCgIKAgoCCgIKAgoCCgIKAgoCovCj4+PiArIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAg oCCgIKAgoCCgIKAgZ290byBvdXQ7Cj4+PiArCj4+PiArIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCg IKAgoCCgIGlmIChidWZmZXJfbWFwcGVkKGJoKSAmJgo+Pj4gKyCgIKAgoCCgIKAgoCCgIKAgoCCg IKAgoCCgIKAgoCCgIKAgZW5kID49IG5ld2V4LT5lY19ibG9jaykgewo+Pj4gKyCgIKAgoCCgIKAg oCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIHN0YXJ0X2luZGV4ID0gaW5kZXggLSAxOwo+Pj4g oCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgLyogZ2V0IHRoZSAxc3QgbWFw cGVkIGJ1ZmZlci4gKi8KPj4+IC0goCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAg oCBpZiAoZW5kID4gbmV3ZXgtPmVjX2Jsb2NrICsKPj4+IC0goCCgIKAgoCCgIKAgoCCgIKAgoCCg IKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIG5ld2V4LT5lY19sZW4pCj4+PiAtIKAgoCCgIKAgoCCg IKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCAvKiBUaGUgYnVmZmVyIGlzIG91dCBv Zgo+Pj4gLSCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCog dGhlIHJlcXVlc3QgcmFuZ2UuCj4+PiAtIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAg oCCgIKAgoCCgIKAgoCCgKi8KPj4+IC0goCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCg IKAgoCCgIKAgoCCgIGdvdG8gb3V0Owo+Pj4goCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAg oCCgIKAgoCCgZ290byBmb3VuZF9tYXBwZWRfYnVmZmVyOwo+Pj4goCCgIKAgoCCgIKAgoCCgIKAg oCCgIKAgoCCgIKAgoH0KPj4+ICsKPj4+IKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKBi aCA9IGJoLT5iX3RoaXNfcGFnZTsKPj4+IKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKBl bmQrKzsKPj4+IKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgfSB3aGlsZSAoYmggIT0gaGVhZCk7Cj4+ Pgo+Pj4gLSCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgLyogTm8gbWFwcGVkIGJ1ZmZlciBmb3VuZC4g Ki8KPj4+IC0goCCgIKAgoCCgIKAgoCCgIKAgoCCgIGdvdG8gb3V0Owo+Pj4gKyCgIKAgoCCgIKAg oCCgIKAgoCCgIKAgLyogTm8gbWFwcGVkIGJ1ZmZlciBpbiB0aGUgcmFuZ2UgZm91bmQgaW4gdGhp cyBwYWdlLAo+Pj4gKyCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCogV2UgbmVlZCB0byBsb29rIHVw IG5leHQgcGFnZS4KPj4+ICsgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAqLwo+Pj4gKyCgIKAgoCCg IKAgoCCgIKAgoCCgIKAgaWYgKGluZGV4ID49IHJldCkgewo+Pj4gKyCgIKAgoCCgIKAgoCCgIKAg oCCgIKAgoCCgIKAgoCAvKiBUaGVyZSBpcyBubyBwYWdlIGxlZnQsIGJ1dCB3ZSBuZWVkIHRvIGxp bWl0Cj4+PiArIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAqIG5ld2V4LT5lY19sZW4u Cj4+PiArIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAqLwo+Pj4gKyCgIKAgoCCgIKAg oCCgIKAgoCCgIKAgoCCgIKAgoCBuZXdleC0+ZWNfbGVuID0gZW5kIC0gbmV3ZXgtPmVjX2Jsb2Nr Owo+Pj4gKyCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCBnb3RvIG91dDsKPj4+ICsgoCCg IKAgoCCgIKAgoCCgIKAgoCCgIH0KPj4+ICsgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIGdvdG8gbmV4 dF9wYWdlOwo+Pj4goCCgIKAgoCCgIKAgoCCgfSBlbHNlIHsKPj4+IKAgoCCgIKAgoCCgIKAgoCCg IKAgoCCgLypGaW5kIGNvbnRpZ3VvdXMgZGVsYXllZCBidWZmZXJzLiAqLwo+Pj4goCCgIKAgoCCg IKAgoCCgIKAgoCCgIKBpZiAocmV0ID4gMCAmJiBwYWdlc1swXS0+aW5kZXggPT0gbGFzdF9vZmZz ZXQpCj4+PiCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgaGVhZCA9IHBhZ2VfYnVmZmVy cyhwYWdlc1swXSk7Cj4+PiCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoGJoID0gaGVhZDsKPj4+ICsg oCCgIKAgoCCgIKAgoCCgIKAgoCCgIGluZGV4ID0gMTsKPj4+ICsgoCCgIKAgoCCgIKAgoCCgIKAg oCCgIHN0YXJ0X2luZGV4ID0gMDsKPj4+IKAgoCCgIKAgoCCgIKAgoH0KPj4+Cj4+PiCgZm91bmRf bWFwcGVkX2J1ZmZlcjoKPj4+IEBAIC0zNzYxLDcgKzM3ODAsNyBAQCBmb3VuZF9tYXBwZWRfYnVm ZmVyOgo+Pj4goCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoGVuZCsrOwo+Pj4goCCgIKAg oCCgIKAgoCCgIKAgoCCgIKB9IHdoaWxlIChiaCAhPSBoZWFkKTsKPj4+Cj4+PiAtIKAgoCCgIKAg oCCgIKAgoCCgIKAgoCBmb3IgKGluZGV4ID0gMTsgaW5kZXggPCByZXQ7IGluZGV4KyspIHsKPj4+ ICsgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIGZvciAoOyBpbmRleCA8IHJldDsgaW5kZXgrKykgewo+ Pj4goCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoGlmICghcGFnZV9oYXNfYnVmZmVycyhw YWdlc1tpbmRleF0pKSB7Cj4+PiCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCg IKBiaCA9IE5VTEw7Cj4+PiCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKBi cmVhazsKPj4+IEBAIC0zNzcxLDggKzM3OTAsMTAgQEAgZm91bmRfbWFwcGVkX2J1ZmZlcjoKPj4+ IKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoGJoID0gTlVMTDsKPj4+IKAg oCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoGJyZWFrOwo+Pj4goCCgIKAgoCCg IKAgoCCgIKAgoCCgIKAgoCCgIKAgoH0KPj4+ICsKPj4+IKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCg IKAgoCCgIKBpZiAocGFnZXNbaW5kZXhdLT5pbmRleCAhPQo+Pj4gLSCgIKAgoCCgIKAgoCCgIKAg oCCgIKAgoCCgIKAgoCCgIKAgoCCgIHBhZ2VzWzBdLT5pbmRleCArIGluZGV4KSB7Cj4+PiArIKAg oCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCBwYWdlc1tzdGFydF9pbmRleF0tPmluZGV4 ICsgaW5kZXgKPj4+ICsgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIC0gc3RhcnRf aW5kZXgpIHsKPj4+IKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoC8qIEJs b2NrcyBhcmUgbm90IGNvbnRpZ3VvdXMuICovCj4+PiCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCg IKAgoCCgIKAgoCCgIKBiaCA9IE5VTEw7Cj4+PiCgIKAgoCCgIKAgoCCgIKAgoCCgIKAgoCCgIKAg oCCgIKAgoCCgIKBicmVhazsKPj4+IC0tCj4+PiAxLjcuNS4xCj4+Pgo+Pj4gLS0KPj4+IFRvIHVu c3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51 eC1leHQ0IiBpbgo+Pj4gdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtl cm5lbC5vcmcKPj4+IE1vcmUgbWFqb3Jkb21vIGluZm8gYXQgoGh0dHA6Ly92Z2VyLmtlcm5lbC5v cmcvbWFqb3Jkb21vLWluZm8uaHRtbAo+Pj4KPj4KPgo+Cj4KPiAtLQo+IEJlc3QgV2lzaGVzCj4g WW9uZ3FpYW5nIFlhbmcKPgo=