From: "Amir G." <amir73il@users.sourceforge.net>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/4] ext4: clone indirect.c file from inode.c
Date: Tue, 28 Jun 2011 10:02:45 +0300 [thread overview]
Message-ID: <BANLkTimxd=5DF41cm19MEj0OMU0POha8jg@mail.gmail.com> (raw)
In-Reply-To: <20110627234156.GG2729@thunk.org>
On Tue, Jun 28, 2011 at 2:41 AM, Ted Ts'o <tytso@mit.edu> wrote:
> On Tue, Jun 21, 2011 at 12:39:27PM +0300, amir73il@users.sourceforge.net wrote:
>> From: Amir Goldstein <amir73il@users.sf.net>
>>
>> The next patch is going to move ext4_ind_ functions to
>> indirect.c. First, we clone the file from inode.c and
>> only leave code that is going to be duplicated in both files.
>> This should keep the deleted lines count from inode.c in the next
>> patch the same as the added lines count to indirect.c.
>
> I really dislike cloning functions. This becomes a maintenance
> headache, since bugs that get fixed in one file might not get
> propagated to another. Since I need to manually move all of the
> functions to verify nothing else changed in patches that do massive
> code movement, I used the first two patches in your patch series, but
> replaced the last two patches in the patch series, and replaced it
> with the following:
>
> A) Move __ext4_check_blockref() to fs/ext4/block_validity.c and
> declare it extern.
>
> B) Move ext4_truncate_failed_write() and blocks_for_truncate() to a
> new function, fs/ext4/truncate.h.
Nice cleanups!
>
> C) Movement of indirect-related code to fs/ext4/indirect.c.
>
Hmm.. in my patch the deleted lines from inode.c matched
the added lines in indirect.c (-1 newline at end of file).
Your patch has:
fs/ext4/indirect.c | 1510 ++++++++++++++++++++++++++++++++++++++++++++++
fs/ext4/inode.c | 1486 ---------------------------------------------
This accounts for 28 lines added by header comment and includes in indirect.c
-1 newline at end of file, so where did 3 more lines go?
I am guessing these are just deleted newlines, but have no way of knowing.
Have you made other (maybe checkpatch) changes while moving or just
removed 'static'
from function declarations?
I am asking just in case I get 'git blamed' for it some day ;-)
Cheers,
Amir.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-06-28 7:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 9:39 [PATCH 0/4] ext4: reduce the size of inode.c amir73il
2011-06-21 9:39 ` [PATCH 1/4] ext4: split ext4_ind_truncate from ext4_truncate amir73il
2011-06-21 9:39 ` [PATCH 2/4] ext4: rename ext4_indirect_* funcs to ext4_ind_* amir73il
2011-06-21 9:39 ` [PATCH 3/4] ext4: clone indirect.c file from inode.c amir73il
2011-06-27 23:41 ` Ted Ts'o
2011-06-27 23:44 ` [PATCH 1/3] ext4: move __ext4_check_blockref to block_validity.c Theodore Ts'o
2011-06-27 23:44 ` [PATCH 2/3] ext4: move common truncate functions to header file Theodore Ts'o
2011-06-27 23:44 ` [PATCH 3/3] ext4: move ext4_ind_* functions from inode.c to indirect.c Theodore Ts'o
2011-06-28 7:02 ` Amir G. [this message]
2011-06-21 9:39 ` [PATCH 4/4] " amir73il
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimxd=5DF41cm19MEj0OMU0POha8jg@mail.gmail.com' \
--to=amir73il@users.sourceforge.net \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).