Re: [RFC] exclude_bitmap and uninit_bg features

[Amir Goldstein <amir73il@gmail.com>]

On Fri, Apr 15, 2011 at 4:54 AM, Amir Goldstein <amir73il@gmail.com> wrote:
> On Wed, Apr 13, 2011 at 9:03 PM, Amir Goldstein <amir73il@gmail.com> wrote:
>> Hi Ted,
>>
>> I have been exploring the possibility to make exclude bitmap a compat feature
>> and I think I have come to a dead end with ext4_init_block_bitmap().
>>
>> On old kernels, this function will disregard the exclude bitmap block and leave
>> it free in the block bitmap.
>>
>> So that leaves us with the less attractive option to make it rocompat,
>> which leads to the following dilemma:
>> Once exclude bitmap is allocated by new mkfs or added by new tune2fs,
>> the fs can no longer be mounted by an older kernel.
>> How can we solve that problem?
>>
>> We could use 2 features:
>> EXT4_FEATURE_COMPAT_EXCLUDE_BITMAP /* exclude bitmap is allocated */
>> EXT4_FEATURE_RO_COMPAT_UNINIT_EXCLUDE /* uninit_bg and exclude_bitmap are set */
>
> I am being silly.
> There is no need for the helper uninit_exclude rocompat feature,
> because I already
> have the rocomat has_snapshot feature, so I can init all bitmaps when
> removing it,
> to keep the exclude bitmap protected.
>
>>
>> New mkfs can allocate exclude bitmaps for uninit groups and set the 2
>> features by default.
>> tune2fs -O ^uninit_exclude can init all groups and remove the rocompat feature,
>> making the fs available for old kernels, while keeping the exclude
>> bitmap intact.
>>
>> Does that make sense to you?
>>
>
> So I have a new, yet simpler, deployment strategy.
> For the next release of e2fsprogs:
> - mke2fs -o has_snapshot will explicitly allocate exclude bitmap and big journal
> - setting/clearing of exclude_bitmap/has_snapshot features by tune2fs
> will not be allowed
>
> ext4 with has_snapshot feature will be mountable read-write by new
> kernels with the
> CONFIG_EXT4_FS_SNAPSHOT config option enabled and will be mountable
> read-only by old kernels and when config option is disabled.
>
> This avoid all backward compatibility issues and will assure that no one tries
> to enable an experimental feature on his root fs.
>
> This also reduces the e2fsprogs patches to tune2fs.
>
> For a future release of e2fsprogs:
> - setting the exclude_bitmap/has_snapshot features by tune2fs will be allowed
> - clearing the exclude_bitmap feature will not be allowed
> - clearing the has_snapshot feature will init all block bitmaps,
> uninit all exclude bitmaps and discard all snapshots
>
> Please approve my plan and I will carry on to submit the reduced set
> of e2fsporgs patches.
>
> Thanks,
> Amir.
>

Hi Yongqiang,

As agreed on today's conf call, setting exclude_bitmap on mkfs time
will be optional (can be configured as default via /etc/mke2fs.conf).
And that adding the exclude_bitmap by tune2fs should be possible
for existing installations.

Of course, setting the snapshots feature will also set the exclude_bitmap
feature.
We also agreed that is it OK to require the flex_bg feature when setting
both exclude_bitmap and uninit_bg features.

I noted that uninit_bg together with exclude_bitmap are not backward compatible
because old kernels do not know how to init a block bitmap which contains
an exclude bitmap block.
I also noted that even current kernels do not know how to init a block bitmap
which contains bitmaps and itables of other group (i.e. flex_bg).
Backward compatibility is maintained by mke2fs, which initiates all
block bitmaps
which contain bitmaps and itables from another group.
This practice should be preserved by future implementations of mke2fs
and resize2fs
(like the new resize ioctl).

Cheers,
Amir.