linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: recursive mtime patches
Date: Wed, 13 Apr 2011 21:16:40 +0200	[thread overview]
Message-ID: <BANLkTinO7G1YxZCP1-PXG5Nvyas=QdAunQ@mail.gmail.com> (raw)
In-Reply-To: <20110412154830.GF5246@quack.suse.cz>

On Tue, Apr 12, 2011 at 5:48 PM, Jan Kara <jack@suse.cz> wrote:
>  Hi,
>
> On Mon 11-04-11 16:37:57, Amir Goldstein wrote:
>> Do you have an uptodate version of your recursive mtime patches?
>> The only version I can find online is the original series from 2007.
>  I've put latest version (against 2.6.37) to
> http://beta.suse.com/private/jack/recursive_mtime/
>

Thanks, I'll see if we can use it for our application.

>> I am interested in the patches for indexdb-like application,
>> so persistence after crash is also important for my use case.
>> Your patches would require the application to perform a full
>> directory scan after crash, right?
>  OK, it depends. Currently, even mtime updates are not reliable (data can
> be written to a file while mtime update is not yet committed).  Recursive

Yes, good point.

> modification stamps have possibly larger race windows but I haven't really
> tried how much (I just know that even mtime races are not that hard to
> trigger if you try). So it really depends on how big reliability do you
> expect and I personally don't find much value in just rescanning and
> checking for mtime after a crash. Reading all the data and doing checksum
> certainly has more value but at a high cost.
>

What do you thing about the approach to store recursively modified dir inodes in
a journal "modified inode descriptor block" and update the recursive mtime of
those dirs on journal recovery?

I would also consider to use a mount option rec_mtime and then just
store recursive
mtime in the directory's inode mtime instead of an extended attribute.
That doesn't break any contract with user space, it's just a re-interpretation
of the dir modification notion.

>                                                        Honza
> --
> Jan Kara <jack@suse.cz>
> SUSE Labs, CR
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-04-13 19:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-11 13:37 recursive mtime patches Amir Goldstein
2011-04-12 15:48 ` Jan Kara
2011-04-13 19:16   ` Amir Goldstein [this message]
2011-04-13 21:39     ` Jan Kara
2011-04-14  7:12       ` Amir Goldstein
2011-04-14  9:21         ` Jan Kara
2011-04-14  9:36           ` Amir Goldstein
2011-04-14  9:49             ` Jan Kara
2011-04-14 10:06               ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTinO7G1YxZCP1-PXG5Nvyas=QdAunQ@mail.gmail.com' \
    --to=amir73il@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).