From: Manish Katiyar <mkatiyar@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
Joel Becker <jlbec@evilplan.org>, "Ted Ts'o" <tytso@mit.edu>,
ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 1/3] jbd2 : Make jbd2 transaction handle allocation to return errors and handle them gracefully.
Date: Sun, 24 Apr 2011 17:06:30 -0700 [thread overview]
Message-ID: <BANLkTinTYfML7uw4-Uq4jzMgTCUadDCpTQ@mail.gmail.com> (raw)
In-Reply-To: <20110204155358.GF4104@quack.suse.cz>
On Fri, Feb 4, 2011 at 7:53 AM, Jan Kara <jack@suse.cz> wrote:
> On Sat 29-01-11 21:40:03, Manish Katiyar wrote:
> Hi Manish,
>
>> Have we reached on any conclusion yet on the function name which I can
>> use to send my updated patch ? My preference from the above list is to
>> use ext4_journal_start_nofs() as that seems the closest match, but I
>> would like hear the conclusion from experts.
> How about "ext4_journal_start_tryhard()"? I don't like "nofs" because
> the fact whether we use GFP_NOFS is separate from the fact whether we are
> able to handle memory allocation failure.
Hi Jan,
Sorry for taking so long to respond to this. I'm sending the updated
set of patches after incorporating your previous comments. As
suggested I have added a wrapper routine ext4_journal_start_tryhard()
for the transaction allocation which can't fail and does
its allocation using GFP_NOFS. Regular ext4_journal_start() uses GFP_KERNEL.
--
Thanks a lot -
Manish
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-04-25 0:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-23 3:32 [PATCH 1/3] jbd2 : Make jbd2 transaction handle allocation to return errors and handle them gracefully Manish Katiyar
2011-01-23 5:40 ` Ted Ts'o
2011-01-23 5:53 ` Manish Katiyar
2011-01-23 6:29 ` Joel Becker
2011-01-24 13:31 ` Jan Kara
2011-01-24 17:20 ` Joel Becker
2011-01-25 11:40 ` Jan Kara
2011-01-25 0:06 ` Andreas Dilger
2011-01-25 11:46 ` Jan Kara
2011-01-30 5:40 ` Manish Katiyar
2011-02-04 15:53 ` Jan Kara
2011-02-04 22:44 ` Manish Katiyar
2011-04-25 0:06 ` Manish Katiyar [this message]
2011-01-25 6:47 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinTYfML7uw4-Uq4jzMgTCUadDCpTQ@mail.gmail.com \
--to=mkatiyar@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=jlbec@evilplan.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).