From: Tahsin Erdogan <tahsin@google.com>
To: "Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger@dilger.ca>,
Khazhismel Kumykov <khazhy@google.com>,
linux-ext4 <linux-ext4@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ext4: Return EIO on read error in ext4_find_entry
Date: Mon, 26 Jun 2017 12:22:02 -0700 [thread overview]
Message-ID: <CAAeU0aOQF=g7zAP5gtOb0ur-zN-crsHTWNbTYJJZvVJa+JoB_w@mail.gmail.com> (raw)
In-Reply-To: <20170624002454.wjieb3ppvljumzzj@thunk.org>
On Thu, Jun 22, 2017 at 4:23 PM, Khazhismel Kumykov <khazhy@google.com> wrote:
> - /* read error, skip block & hope for the best */
> EXT4_ERROR_INODE(dir, "reading directory lblock %lu",
> (unsigned long) block);
> brelse(bh);
> - goto next;
> + ret = ERR_PTR(-EIO);
> + goto cleanup_and_exit;
EXT4_ERROR_INODE() triggers ext4_handle_error() which performs error
handling. I think it should be removed here because we are returning
the error to the caller and there is nothing more drastic about this
error than other error return paths in the same function.
next prev parent reply other threads:[~2017-06-26 19:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 23:23 [PATCH] ext4: Return EIO on read error in ext4_find_entry Khazhismel Kumykov
2017-06-23 4:43 ` Theodore Ts'o
2017-06-23 6:33 ` Andreas Dilger
2017-06-23 12:26 ` Theodore Ts'o
2017-06-23 21:36 ` Andreas Dilger
2017-06-23 22:33 ` Khazhismel Kumykov
2017-06-23 23:26 ` Theodore Ts'o
2017-06-23 23:34 ` Andreas Dilger
2017-06-24 0:24 ` Theodore Ts'o
2017-06-26 19:22 ` Tahsin Erdogan [this message]
2017-06-26 20:45 ` Andreas Dilger
2017-06-27 21:58 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAeU0aOQF=g7zAP5gtOb0ur-zN-crsHTWNbTYJJZvVJa+JoB_w@mail.gmail.com' \
--to=tahsin@google.com \
--cc=adilger@dilger.ca \
--cc=khazhy@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).