From: Jesse Grodman <jgrodman@gmail.com>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: Suggested change for superblock journal hint
Date: Mon, 18 Nov 2019 00:14:07 +0200 [thread overview]
Message-ID: <CACtp79BMK8yEVFar4Sc3iABbatJVDppqMR4w=bRgY50dVmtppA@mail.gmail.com> (raw)
In-Reply-To: <20191114172754.GB4579@mit.edu>
Sorry, and got it. I asked my employer but it can take a while to get
a response, so feel free to make the change yourself if you'd like.
I'd be curious if you think it is a good change.
Best,
Jesse
On Thu, Nov 14, 2019 at 7:27 PM Theodore Y. Ts'o <tytso@mit.edu> wrote:
>
> On Thu, Nov 14, 2019 at 05:05:06PM +0200, Jesse Grodman wrote:
> > Hi,
> >
> > I encountered the scenario that a full fsck check was being run
> > unnecessarily when the major / minor number of my external journal was
> > being fixed by fsck. This PR changes that so that this change does
> > trigger the full fsck run: github.com/tytso/e2fsprogs/pull/26
>
> Hi Jessie,
>
> It's preferable that patches e2fsprogs be sent to the linux-ext4 list,
> so they can get reviewed by the full ext4 community. That being said,
> I will accept minor patches sent via a pull request if they full meet
> the requirements for kernel patches:
>
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
>
> Note in particular the requirements for the Developer's Certification
> of Origin (aka the Signed-off-by tag). That has specific legal
> meanings (for example, you are certifying that your employer allows
> you to contribute to open source projects, or at least, *this* open
> source project), so please take a close look at that.
>
> Cheers,
>
> - Ted
prev parent reply other threads:[~2019-11-17 22:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 15:05 Suggested change for superblock journal hint Jesse Grodman
2019-11-14 17:27 ` Theodore Y. Ts'o
2019-11-17 22:14 ` Jesse Grodman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACtp79BMK8yEVFar4Sc3iABbatJVDppqMR4w=bRgY50dVmtppA@mail.gmail.com' \
--to=jgrodman@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).