From: harshad shirwadkar <harshadshirwadkar@gmail.com>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger@dilger.ca>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 01/11] ext4: add handling for extended mount options
Date: Mon, 22 Jul 2019 14:36:09 -0700 [thread overview]
Message-ID: <CAD+ocbyG6_GK-SMotXgm7OmBLmjiRPWMHH0oryYS=gQ7fbPBxA@mail.gmail.com> (raw)
In-Reply-To: <20190722210235.GE16313@mit.edu>
Thanks Andreas. Thanks Ted for sharing the original paper link. I'll
submit a patch 00/11 with proposed documentation and cover letter
describing the feature and results from benchmarks.
On Mon, Jul 22, 2019 at 2:02 PM Theodore Y. Ts'o <tytso@mit.edu> wrote:
>
> On Mon, Jul 22, 2019 at 12:15:11PM -0600, Andreas Dilger wrote:
> > Unless I missed it, this patch series needs a 00/11 email that describes
> > *what* "fast commit" is, and why we want it. This should include some
> > benchmark results, since (I'd assume) that the "fast" part of the feature
> > name implies a performance improvement?
>
> For background, it's a simplified version of the scheme proposed by
> Park and Shin, in their paper, "iJournaling: Fine-Grained Journaling
> for Improving the Latency of Fsync System Call"[1]
>
> [1] https://www.usenix.org/conference/atc17/technical-sessions/presentation/park
>
> I agree we should have a cover letter for this patch series. Also, we
> should add documentation to Documentation/filesystems/journaling.rst
> about this feature; what it does, how it works, its basic on-disk
> format changes, etc.
>
> The fs/jbd2 layer isn't as well documented as the fs/ext4 code, and
> bringing Documentation/filesystems/journaling.rst to the same level as
> Documentation/filesystems/ext4/* isn't a fair/reasonable request. On
> the other hand, documenting what is being added by this patch series
> is something that I think we should do.
>
> - Ted
next prev parent reply other threads:[~2019-07-22 21:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 4:00 [PATCH 01/11] ext4: add handling for extended mount options Harshad Shirwadkar
2019-07-22 4:00 ` [PATCH 02/11] jbd2: add fast commit fields to journal_s structure Harshad Shirwadkar
2019-07-22 4:00 ` [PATCH 03/11] jbd2: fast commit setup and enable Harshad Shirwadkar
2019-07-22 4:00 ` [PATCH 04/11] jbd2: fast-commit commit path changes Harshad Shirwadkar
2019-07-22 4:00 ` [PATCH 05/11] jbd2: fast-commit commit path new APIs Harshad Shirwadkar
2019-07-22 17:45 ` kbuild test robot
2019-07-22 21:02 ` kbuild test robot
2019-07-22 4:00 ` [PATCH 06/11] jbd2: fast-commit recovery path changes Harshad Shirwadkar
2019-07-22 4:00 ` [PATCH 07/11] ext4: add fields that are needed to track changed files Harshad Shirwadkar
2019-07-22 4:00 ` [PATCH 08/11] ext4: track changed files for fast commit Harshad Shirwadkar
2019-07-22 4:00 ` [PATCH 09/11] ext4: fast-commit commit range tracking Harshad Shirwadkar
2019-07-22 4:00 ` [PATCH 10/11] ext4: fast-commit commit path changes Harshad Shirwadkar
2019-07-22 4:00 ` [PATCH 11/11] ext4: fast-commit recovery " Harshad Shirwadkar
2019-07-22 21:34 ` kbuild test robot
2019-07-22 18:15 ` [PATCH 01/11] ext4: add handling for extended mount options Andreas Dilger
2019-07-22 21:02 ` Theodore Y. Ts'o
2019-07-22 21:36 ` harshad shirwadkar [this message]
2019-07-23 21:59 ` Andreas Dilger
2019-07-24 6:03 ` harshad shirwadkar
2019-07-24 6:12 ` Darrick J. Wong
2019-07-24 16:07 ` Theodore Y. Ts'o
2019-07-24 16:56 ` Darrick J. Wong
2019-07-24 18:14 ` harshad shirwadkar
2019-07-25 3:46 ` Theodore Y. Ts'o
2019-07-25 20:03 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD+ocbyG6_GK-SMotXgm7OmBLmjiRPWMHH0oryYS=gQ7fbPBxA@mail.gmail.com' \
--to=harshadshirwadkar@gmail.com \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).