linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ralph Siemsen <ralph.siemsen@linaro.org>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger@dilger.ca>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH RFC 2/3] mke2fs.c: fail on multiple '-E' options
Date: Fri, 19 Sep 2025 11:44:17 -0400	[thread overview]
Message-ID: <CANp-EDYrY0W6LE_1kc0NvhyOS65UW4znYZ_suFUQO+zxvQDA=Q@mail.gmail.com> (raw)
In-Reply-To: <CANp-EDagbnACsxtY5MT0yJk3tEuV=R2kapvKVNvua5azD3UyzQ@mail.gmail.com>

Hi Andreas and Ted,

On Wed, Sep 10, 2025 at 5:31 PM Ralph Siemsen <ralph.siemsen@linaro.org> wrote:
> On Wed, Sep 10, 2025 at 4:45 PM Theodore Ts'o <tytso@mit.edu> wrote:
>
> > So in PRS, we need to save each of the -E arguments --- or concatenate
> > them together into a single set of extended options, and keep the call
> > site for parse_extended_options() them where it currently is located
>
> That what I am doing in patch v2:
> https://lore.kernel.org/linux-ext4/20250910-mke2fs-small-fixes-v2-2-55c9842494e0@linaro.org/T/#u
> It makes use of the already existing push_string() helper, to make
> copies of each argument.

Any feedback on the v2 patch series [1]? If you prefer another
approach (such as concatenating extended options) please let me know.

Also any comments regarding the other changes, particularly the
addition of root_selinux extended option?

[1] https://lore.kernel.org/linux-ext4/20250910-mke2fs-small-fixes-v2-0-55c9842494e0@linaro.org/

Thanks,
-Ralph

  reply	other threads:[~2025-09-19 15:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09 15:40 [PATCH RFC 0/3] mke2fs: small doc and features Ralph Siemsen
2025-09-09 15:40 ` [PATCH RFC 1/3] mke2fs: document the hash_seed option Ralph Siemsen
2025-09-09 15:40 ` [PATCH RFC 2/3] mke2fs.c: fail on multiple '-E' options Ralph Siemsen
2025-09-10  0:32   ` Andreas Dilger
2025-09-10  0:49     ` Ralph Siemsen
2025-09-10 14:52       ` Theodore Ts'o
2025-09-10 15:00         ` Theodore Ts'o
2025-09-10 16:29         ` Ralph Siemsen
2025-09-10 20:45           ` Theodore Ts'o
2025-09-10 21:31             ` Ralph Siemsen
2025-09-19 15:44               ` Ralph Siemsen [this message]
2025-09-09 15:40 ` [PATCH RFC 3/3] mke2fs: add root_selinux option for root inode label Ralph Siemsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANp-EDYrY0W6LE_1kc0NvhyOS65UW4znYZ_suFUQO+zxvQDA=Q@mail.gmail.com' \
    --to=ralph.siemsen@linaro.org \
    --cc=adilger@dilger.ca \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).