linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Wang Sheng-Hui <shhuiw@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Jan Kara <jack@suse.cz>,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jbd: change the field "b_cow_tid" of struct journal_head from type unsigned to tid_t
Date: Mon, 25 Jul 2011 16:25:39 +0300	[thread overview]
Message-ID: <CAOQ4uxhGceySNm7-d=NdjPVZDsb4Pi8Gobf145zdDomZqhJCyQ@mail.gmail.com> (raw)
In-Reply-To: <4E2D6961.9000909@gmail.com>

On Mon, Jul 25, 2011 at 4:02 PM, Wang Sheng-Hui <shhuiw@gmail.com> wrote:
> The patch is against 3.0
>
> In the definition of struct journal_head, the comment for
> the field "unsigned b_cow_tid" says the field tracks the
> last transaction id in which this buffer has been cowed.
>
> In the header part of file journal-head.h, it defines
>   typedef unsigned int  tid_t;
> We should use type tid_t to define transaction id fields.
>
> Change the field "b_cow_tid" of struct journal_head from
> type unsigned to tid_t.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>

my bad.

Acked-by: Amir Goldstein <amir73il@users.sf.net>

> ---
>  include/linux/journal-head.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/journal-head.h b/include/linux/journal-head.h
> index 44e95d0..423cb6d 100644
> --- a/include/linux/journal-head.h
> +++ b/include/linux/journal-head.h
> @@ -45,7 +45,7 @@ struct journal_head {
>         * has been cowed
>         * [jbd_lock_bh_state()]
>         */
> -       unsigned b_cow_tid;
> +       tid_t b_cow_tid;
>
>        /*
>         * Copy of the buffer data frozen for writing to the log.
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-07-25 13:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-25 13:02 [PATCH] jbd: change the field "b_cow_tid" of struct journal_head from type unsigned to tid_t Wang Sheng-Hui
2011-07-25 13:25 ` Amir Goldstein [this message]
2011-07-25 13:44 ` Christoph Hellwig
2011-07-25 14:19   ` Amir Goldstein
2011-07-25 15:31 ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOQ4uxhGceySNm7-d=NdjPVZDsb4Pi8Gobf145zdDomZqhJCyQ@mail.gmail.com' \
    --to=amir73il@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shhuiw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).