Re: [PATCH] e2fsprogs: misc/mke2fs.8.in: Update default inode size description

[Andreas Dilger <adilger@dilger.ca>]

[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]

On Apr 17, 2024, at 5:48 AM, Pascal Hambourg <pascal@plouf.fr.eu.org> wrote:
> 
> Since a23b50cd ("mke2fs: warn about missing y2038 support when
> formatting fresh ext4 fs"), the default inode size is 256 bytes
> for all filesystems, including small and floppy, except for the
> Hurd since it currently only supports 128-byte inodes.
> 
> Signed-off-by: Pascal Hambourg <pascal@plouf.fr.eu.org>

Looks good.

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> misc/mke2fs.8.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/misc/mke2fs.8.in b/misc/mke2fs.8.in
> index 30f97bb5..8122e7f7 100644
> --- a/misc/mke2fs.8.in
> +++ b/misc/mke2fs.8.in
> @@ -508,8 +508,8 @@ The default inode size is controlled by the
> file.  In the
> .B mke2fs.conf
> file shipped with e2fsprogs, the default inode size is 256 bytes for
> -most file systems, except for small file systems where the inode size
> -will be 128 bytes.
> +all file systems, except for the GNU Hurd since it only supports
> +128-byte inodes.
> .TP
> .B \-j
> Create the file system with an ext3 journal.  If the
> --
> 2.39.2


Cheers, Andreas






[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]