From: "Yoann Congal" <yoann.congal@smile.fr>
To: "Yoann Congal" <yoann.congal@smile.fr>, <stable@vger.kernel.org>
Cc: <linux-ext4@vger.kernel.org>,
"Andreas Dilger" <adilger.kernel@dilger.ca>,
"Theodore Ts'o" <tytso@mit.edu>,
"Baokun Li" <libaokun1@huawei.com>, "Jan Kara" <jack@suse.cz>,
"Ojaswin Mujoo" <ojaswin@linux.ibm.com>
Subject: Re: [PATCH 6.6.y] ext4: get rid of ppath in get_ext_path()
Date: Fri, 03 Jul 2026 18:20:27 +0200 [thread overview]
Message-ID: <DJP2NAVND6C3.34I2E0R3EDJPD@smile.fr> (raw)
In-Reply-To: <20260702154810.3435236-1-yoann.congal@smile.fr>
On Thu Jul 2, 2026 at 5:48 PM CEST, Yoann Congal wrote:
> From: Baokun Li <libaokun1@huawei.com>
>
> [ Upstream commit 6b854d552711aa33f59eda334e6d94a00d8825bb ]
>
> The use of path and ppath is now very confusing, so to make the code more
> readable, pass path between functions uniformly, and get rid of ppath.
>
> After getting rid of ppath in get_ext_path(), its caller may pass an error
> pointer to ext4_free_ext_path(), so it needs to teach ext4_free_ext_path()
> and ext4_ext_drop_refs() to skip the error pointer. No functional changes.
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Reviewed-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
> Tested-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
> Link: https://patch.msgid.link/20240822023545.1994557-13-libaokun@huaweicloud.com
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
>
> Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
> ---
Hello,
I missed it at first but a discussion about the same issue is happening
here:
https://lore.kernel.org/all/tencent_C982B0201FE8F041BD5B4FC1ED7D646A740A@qq.com/
But the above is a partial backport whereas mine is the full backport.
Regards,
--
Yoann Congal
Smile ECS
next prev parent reply other threads:[~2026-07-03 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 15:48 [PATCH 6.6.y] ext4: get rid of ppath in get_ext_path() Yoann Congal
2026-07-03 16:20 ` Yoann Congal [this message]
2026-07-04 2:04 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJP2NAVND6C3.34I2E0R3EDJPD@smile.fr \
--to=yoann.congal@smile.fr \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=libaokun1@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox