From: Andreas Dilger <adilger@sun.com>
To: tytso@mit.edu
Cc: linux-ext4@vger.kernel.org
Subject: Re: Please reserve INCOMPAT flags
Date: Sun, 24 Jan 2010 23:18:47 -0700 [thread overview]
Message-ID: <E1520682-CD9F-445E-AF33-D5FCDABA1FF8@sun.com> (raw)
In-Reply-To: <20100124194839.GB4372@thunk.org>
On 2010-01-24, at 12:48, tytso@mit.edu wrote:
> On Sun, Sep 06, 2009 at 11:25:46AM +0200, Andreas Dilger wrote:
>> in addition to the data-in-dirent INCOMPAT flag Rahul sent the
>> patches
>> for last week, I would like to ensure that we also have the INCOMPAT
>> flag for large EA-in-inode flag reserved. This patch is going into
>> testing at one of our large customers, and I want to make sure that
>> we don't accidentally get a conflicting INCOMPAT flag assignment.
>>
>> #define EXT4_FEATURE_INCOMPAT_EA_INODE 0x0400
>> #define EXT4_FEATURE_INCOMPAT_DIRDATA 0x1000
>>
>> #define EXT4_EA_INODE_FL 0x00200000 /* Inode used for large EA */
>
> Reserving... but stupid question, do you know if anyone is currently
> using the inode flag 0x00100000? I want to make sure that's properly
> documented and reserved.
It doesn't seem that ext2/3/4 are using the 0x00100000 value itself,
but it seems the VFS is using this value for FS_DIRECTIO_FL. Should
we reserve this in the ext4 flags also, to avoid collisions? I'm not
sure what that flag is for, possibly to force all IO to the file to be
uncached?
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
next prev parent reply other threads:[~2010-01-25 6:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-06 9:25 Please reserve INCOMPAT flags Andreas Dilger
2009-11-30 19:15 ` Andreas Dilger
2009-11-30 19:31 ` Please reserve INCOMPAT_EA_INODE flag Andreas Dilger
2009-11-30 21:16 ` [PATCH] Please reserve INCOMPAT_DIRDATA flag Andreas Dilger
2010-06-02 14:34 ` tytso
2010-06-02 14:34 ` Please reserve INCOMPAT_EA_INODE flag tytso
2009-12-05 4:25 ` Please reserve INCOMPAT flags Aneesh Kumar K.V
2010-01-24 19:48 ` tytso
2010-01-25 6:18 ` Andreas Dilger [this message]
2010-01-25 8:06 ` Motion to nuke FS_DIRECTIO_FL tytso
2010-01-25 9:31 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1520682-CD9F-445E-AF33-D5FCDABA1FF8@sun.com \
--to=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).